fix: recover add-node coverage after profile changes - #188
Open
anthony-at-pieces wants to merge 1 commit into
Open
fix: recover add-node coverage after profile changes#188anthony-at-pieces wants to merge 1 commit into
anthony-at-pieces wants to merge 1 commit into
Conversation
Collaborator
|
Were you able to reproduce 185? I can't. Any change to the list of enabled profiles should trigger a cache clear and re-fetch already. |
Contributor
Author
|
Not on a device - I don't have ios - but I reproduced it in a widget test so I could verify red/green - you are right, the profile change triggers a cache clear and refetch at the map/cache layer, but the bug was in the sheet's own request dedupe - after one successful area request - the sheet suppressed re-requesting even after it's cached coverage was invalid underneath. So the re-fetch never reached the sheet's target area while it sat open. my bad I should have been more explicit in that - with that information, you might be able to recreate? the "widget" test is checked in on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
flutter test test/widgets/add_node_sheet_coverage_recovery_test.dartflutter analyze --no-fatal-infosflutter testCloses #185