Skip to content

Variant Maker SKU summary leaves out "used on another product" #53

Description

@wmdhosting

Summary

The Variant Maker flags three SKU problems per row: skuDuplicate, skuTaken ("A variant on another product already uses this SKU.") and skuTooLong. The summary above the preview (variantMaker.skuIssues) and the message when Generate is refused (variantMaker.skuIssuesBlockGenerating) only mention the first and last:

Fix the SKU format. One row builds a duplicate SKU, or a SKU longer than 255 characters.

When every flagged row is skuTaken, the summary names two causes that don't apply, and the real one only shows in the row itself.

Suggested fix

Either make the summary generic ("{count} rows have a SKU problem, see the rows below."), or collect which issue types are present in flagSkuIssues() and list only those.

Files: translations/en/variant-manager.php (variantMaker.skuIssues, variantMaker.skuIssuesBlockGenerating), templates/variant-maker/_preview.twig:15, controllers/VariantMakerController.php:75.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions