Repository navigation
Reorganize the for-each quantifier matchers in QuantifierMatchers - #4690
Merged
Merged
Conversation
robert-brunel
commented
Sep 29, 2026
robert-brunel
force-pushed
the
apple/robert-brunel/noe-2
branch
from
October 5, 2026 15:28
49888f1 to
4b7d52e
Compare
normen662
approved these changes
Oct 9, 2026
* Add `Quantifier.ForEach.isPlain()` and the `plainForEachQuantifier()` and `plainForEachQuantifierOverRef()` matchers, which match plain for-each quantifiers only. * Replace `forEachQuantifierWithoutDefaultOnEmptyOverRef()` with `plainForEachQuantifierOverRef()`, and `forEachQuantifierWithDefaultOnEmptyOverRef()` with a `withNullOnEmpty()` constraint. * Remove the unused variants `forEachQuantifier(CollectionMatcher)`, `forEachQuantifierWithDefaultOnEmpty()`, `forEachQuantifierOverPlans()` and the two-argument `forEachQuantifierOverRef()`. * Document the class and all its methods.
robert-brunel
force-pushed
the
apple/robert-brunel/noe-2
branch
from
October 9, 2026 15:12
4b7d52e to
291c10a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quantifier.ForEach.isPlain()method and theplainForEachQuantifier()andplainForEachQuantifierOverRef()matchers, which match plain for-each quantifiers only.forEachQuantifierWithoutDefaultOnEmptyOverRef()withplainForEachQuantifierOverRef(), andforEachQuantifierWithDefaultOnEmptyOverRef()with awithNullOnEmpty()constraint.forEachQuantifier(CollectionMatcher),forEachQuantifierWithDefaultOnEmpty(),forEachQuantifierOverPlans()and the two-argumentforEachQuantifierOverRef().This is a pre-refactoring for #4489.