Repository navigation
chore: publish to npm by hand, not from the release workflow - #19
Open
FrancoisChastel wants to merge 1 commit into
Open
FrancoisChastel wants to merge 1 commit into
FrancoisChastel wants to merge 1 commit into
Conversation
Every published version so far went to npm by hand, and the workflow's npm step only ever warned that NPM_TOKEN was missing. Make that the documented process: the workflow checks the tag and creates the GitHub release, and the maintainer runs `npm publish` from a clean checkout of the tag once it passes (prepublishOnly still runs the full check). Drop `provenance` from publishConfig and the id-token permission, which only CI publishing used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Releases reach npm by hand from now on. Every published version (0.2.1 to 0.4.0) already went out that way, and the workflow's npm step only ever warned that
NPM_TOKENwas missing.release.ymlkeeps running the checks on the tagged commit, verifying the tag againstpackage.json, and creating the GitHub release. The npm token check andnpm publishstep are gone, along with theid-tokenpermission and registry setup they needed.publishConfigdropsprovenance, which only works from CI.prepublishOnlystill runsnpm run checkfirst.How to verify
Checklist
npm run checkpassesCHANGELOG.mdentry under Unreleased