Repository navigation
Conversation
Step 9 of #412 asks for headless tests in the Linux CI that create, measure and export a text and check that the process survives the finalizers. Creating and measuring was already tested with the font service; these tests add: - saving a text to JSON and reading it back, with the same extent; - exporting a text to DXF and reading it back (string, size, location, and an extent measured with the managed font reader); - running the finalizers after texts have been measured and outlined. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YXvDW91oXpy7RquGHNxgR5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #412, step 9 (verification on non-Windows hosts). This PR is stacked on #472 because it needs the font service of the kernel (#468 and its successors). Its base is
feature/gdi-glyph-comparison; it will be retargeted as the stack is merged.What step 9 asks for
Headless tests in the Linux CI that create, measure and export a
Text, and check that the process survives the finalizers.Creating and measuring a text without a frame and without GDI is already tested since #468 (
FontProviderTests.TextWorksWithoutFrameAndWithoutGdi,FontCacheHasNoFinalizerThatCanCrashTheProcess). This PR adds the export.Tests
HeadlessTextExportTests, using the font Liberation Sans from the test fonts:Project.Export(…, "dxf")and imported again. The test checks the string, the size and the location, and that the imported text gets an extent measured by the managed font reader.GC.Collect,WaitForPendingFinalizersandGC.Collectrun. A finalizer that throws would end the test host and fail the run. That is exactly what the GDIFontCachedid on Linux before Get the fonts of texts from a font service of the kernel instead of GDI #468.STL export is not tested, because
PaintToSTLdoes not triangulate texts (TriangulateTextis alwaysfalse). Texts are left out of STL files on every platform.Local run (Linux):
CADability.Tests: 654 passed, 12 skipped.🤖 Generated with Claude Code
https://claude.ai/code/session_01YXvDW91oXpy7RquGHNxgR5
Generated by Claude Code