Repository navigation
Conversation
ModelView.GetContentsAsBitmap, OpenGlCustomize.PaintToBitmap and Substitutes.PaintEventArgs.Graphics are removed in 2.0 but were not [Obsolete] yet. Their messages name the replacement, as #412 requires: - GetContentsAsBitmap always returned null, and OpenGlCustomize.PaintToBitmap always threw. Both point to CADability.Forms.PaintToOpenGL.PaintToBitmap, which already implements the same signature. - No view of CADability reads PaintEventArgs.Graphics; views paint through ICanvas.PaintTo3D. CadCanvas keeps setting it for application views. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YXvDW91oXpy7RquGHNxgR5
Collaborator
Author
|
Closing without merge. These Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #412. Against
master, independent of the other #412 PRs.Why
Breaking changes in 2.0 in #412 lists three class members that no open PR had marked
[Obsolete]yet. The acceptance criteria require every class member removed in 2.0 to be[Obsolete]in 1.x, naming its replacement.What
[Obsolete]ModelView.GetContentsAsBitmap()nullCADability.Forms.PaintToOpenGL.PaintToBitmapOpenGlCustomize.PaintToBitmap(…)NotImplementedExceptionCADability.Forms.PaintToOpenGL.PaintToBitmap, which has the same signature and worksSubstitutes.PaintEventArgs.GraphicsCadCanvas, read by no view of CADabilityICanvas.PaintTo3DCadCanvaskeeps settingGraphics, with the warning suppressed, so that views of applications that read it keep working until 2.0.Deviations from the list in #412
GetContentsAsBitmap()andOpenGlCustomize.PaintToBitmap(…)"no longer return a GDI+Bitmap". This PR adds no kernel method that returns encoded image bytes instead. Neither method has ever worked in the kernel, and a working replacement already exists inCADability.Forms, so a new kernel API would only add surface. That can still come in 2.0 if a headless snapshot is wanted.feature/png-snapshotscomes from that dropped plan. Pushes from this session cannot rename or delete branches.Testing
CADability.Formsbuilds without new warnings.CADability.Testson Linux: 624 passed, 18 skipped, 0 failed.🤖 Generated with Claude Code
https://claude.ai/code/session_01YXvDW91oXpy7RquGHNxgR5
Generated by Claude Code