[TASK] Keep implementation, schema and documentation in sync - #566
Conversation
|
@schliesser thanks! This is massive.. will need to check and verify whether these are all valid. Regarding SelectText and SelectNumber: These are by intention without item processors, so the DefaultSchema can automatically derive a varchar / int DB field. So this can be removed again. Give me some time to read this thoroughly. |
16d53d5 to
885e9b9
Compare
|
@nhovratov thank you very much for reviewing it. Yes it got massive quiet quickly 🙈 The SelectText and SelectNumber fields have no item processors anymore. SelectText did make use of Trait WithCustomProperties, which is removed now. Let me know what else to change :-) |
cd57b78 to
b2fc492
Compare
b2fc492 to
82dd138
Compare
|
@schliesser Perfect. I only removed |
The JSON schemas, the Field Type classes and the YAML reference had drifted apart: valid configuration was rejected by content-blocks:lint, while other properties were allowed but never read at runtime.
Align all three sides:
Add two guards so the three sides cannot drift again: SchemaFieldTypeSyncTest covers schema <-> implementation, and Build/Scripts/checkDocumentationSync.php reports schema <-> documentation. Both derive Field Types, their settings, their schema branch and the centrally declared properties from the sources themselves, so adding a Field Type needs no bookkeeping.
Resolves: #562