Repository navigation
Simplify search and reduce context overhead - #90
Conversation
There was a problem hiding this comment.
Ponytail review of #90. Original review findings below.
Applied in b77424a after approval: removed all three identified legacy paths, migrated coverage without reducing the 432-test count, and removed 239 lines net (246 production-source lines). Release handoff remains intact. Local validation, 419 extracted-source regression tests, and installed Pi 1.4.0 loading passed.
Release preparation is included in 595cbf2: Unreleased changelog, breaking 0.3.1 → 0.4.0 migration guidance, and an exact post-merge preparation command. The existing checker rejects bundled feature/version changes and publication requires a merged release/next PR, so the actual release plan/version bump must remain a post-merge release-only PR. No workflow was dispatched and nothing was published.
Validation: 432 package tests, 25 tooling tests, lint, typecheck, production audit, clean-consumer packaging, 419 extracted-source regression tests, in-memory release generation, and offline loading against the operator's installed Pi 1.4.0 passed. All PR checks passed on 595cbf2.
-
pi-web-search/src/index.ts:L56: delete: unified registration leaves
web_search.ts,code_search.ts, andmulti_search.tswith test-only callers; their three schemas and dispatch wrappers still ship in the tarball (161 lines). Port the applicable fixture coverage tosearch()/executeSearch()and delete the three obsolete modules; no compatibility wrappers are needed for unregistered tools. -
pi-web-search/src/search_read.ts:L247: delete: the zero-based
searchRead()implementation andSearchReadSchemaare used only by tests; registered ref calls already usesearchReadRef(). Migrate those fixtures to one-based refs and remove the legacy reader/schema and its sole whole-result accessor,EvidenceStore.get()atsrc/evidence.ts:L83; keep the targeted listing/hit accessors and their safety coverage. -
pi-web-search/src/format.ts:L145: delete: removing the Coverage renderer leaves
StreamResult.skippedwithout a reader.execute.tsstill computes it throughskippedSources()and threads it through judging/storage, but neither renderer details nor the structured schema exposes it. Remove that calculation/helper, itsDEFAULT_CHAINimport, the unused type field, and the obsolete fixture field; retain the separate provider warnings and availability checks.
No ponytail: debt. Clean ledger.
net: -245 lines possible.
/web-search classifier.