Repository navigation
chore(build): avoid downloading grevm test data during compilation - #822
Merged
Merged
Conversation
nekomoto911
approved these changes
Aug 20, 2026
2 of 3 tasks
nekomoto911
added a commit
that referenced
this pull request
Aug 20, 2026
## Summary
- Gate PR-wide dedup (`belongs_to_pr`) used `GET /commits/{sha}/pulls`,
which returns `[]` for commits that only exist on **open** PRs.
- That made every re-approve after the first successful run treat the PR
as "never passed" and re-run E2E/UT (seen on #819 after merge-from-main
+ re-approve).
- Switch the membership check to `GET /pulls/{n}/commits` (paginated),
which correctly lists open-PR commits and still rejects SHAs from a
reused branch name / foreign PR.
## Test plan
- [x] Locally replay gate logic against #819: previous success run
`32322914975` (`1e6e4a8`) is recognized → would `should_run=false`.
- [x] Foreign SHA from merged #822 is rejected.
- [ ] After merge: on a PR that already has a successful E2E/UT run,
re-approve (optionally after a docs-only or merge-from-main commit) and
confirm Gate logs `CI already passed for PR #N. Skipping.` with
downstream jobs skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow Galxe/gravity-reth#428