Respect features when building CMake examples#230
Merged
Conversation
zayenz
force-pushed
the
feature/feature-aware-cmake-examples
branch
from
4ded0ba to
d7c965f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake currently enables the set and float modules whenever examples are requested, overriding explicit feature choices. The example targets therefore do not follow the same feature groups as the Autotools build.
Keep optional variable modules disabled when requested and select set, float, and MPFR examples from explicit groups. Minimodel also links the set library only when set variables are enabled.
The CI smoke test checks integer-only target selection, builds an integer example, and verifies the set, float, and MPFR target groups. I also built integer-only, set-enabled, and float-without-MPFR configurations locally.
Closes #83.