Preserve Gist mode with statistics#232
Draft
zayenz wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FlatZinc option parsing changed the execution mode to stat whenever -s was present, even when -mode gist had been selected explicitly. Argument order did not help because the override happened after parsing.
Keep -s as the statistics shorthand for ordinary solution mode, but preserve an explicit Gist mode in either argument order.
When Gist support is compiled out, reject Gist execution before search with a clear FlatZinc error instead of silently falling through to ordinary solution mode. The run-level regression parses and prepares a real model, then verifies that -mode gist -s raises the unavailable-mode error without producing a solution.
The focused FlatZinc option tests are included in both the CMake and Autotools fast-check selections.
Checks:
Closes #99.