Skip to content

Promote integration to main - #286

Merged
rocklambros merged 12 commits into
mainfrom
integration
Oct 16, 2026
Merged

rocklambros merged 12 commits into
mainfrom
integration

Conversation

@rocklambros

Copy link
Copy Markdown
Collaborator

11 commit(s) ahead. Merging publishes the site and every schema $id URI. Merge with a merge commit, not a squash: squashing flattens the specification history that makes a schema change reviewable later.

What this ships

This is release 0.1.4. Merging it changes version.txt on main, so tag-release.yml tags v0.1.4. The full list is in the 0.1.4 section of CHANGELOG.md (PR #281).

The Trace changes are breaking in principle, while the spec version stays v0.1.0. No producer in this repository is affected, because the reference exporter already conforms and nothing here emits OCSF yet.

rocklambros and others added 11 commits October 9, 2026 07:01
Signed-off-by: Rock Lambros <rock@rockcyber.com>
Closes #57
Closes #58

Signed-off-by: Saba Siddique <sabasiddiqdev@gmail.com>
Signed-off-by: Rock Lambros <rock@rockcyber.com>
Closes #121

Signed-off-by: Rock Lambros <rock@rockcyber.com>
Closes #227

Signed-off-by: Rock Lambros <rock@rockcyber.com>
Closes #91

Signed-off-by: Saba Siddique <sabasiddiqdev@gmail.com>
Signed-off-by: Rock Lambros <rock@rockcyber.com>
Closes #228
Closes #263

Signed-off-by: Rock Lambros <rock@rockcyber.com>
…ollector setup (#277)

Closes #266
Closes #276
Refs #274

Signed-off-by: Rock Lambros <rock@rockcyber.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Rock Lambros <rock@rockcyber.com>
…y, and stop everything before a rerun (#279)

Refs #274

Signed-off-by: Rock Lambros <rock@rockcyber.com>
)

Refs #266
Refs #91

Signed-off-by: Rock Lambros <rock@rockcyber.com>
Refs #91
Refs #228

Signed-off-by: Rock Lambros <rock@rockcyber.com>
@rocklambros

Copy link
Copy Markdown
Collaborator Author

@afogel @bar-capsule, this is the step that ships 0.1.4, and it needs an approval from one of you. It promotes everything from this week from integration to main, and merging it tags v0.1.4. The changes have already been reviewed on their own PRs, which are listed in the description, so this is a check that the set is right, not a line-by-line review. The CHANGELOG's 0.1.4 section is the best single place to read it. Please approve rather than using "Commit suggestion", because a commit here would make you the last pusher. I'll merge it with a merge commit, which is what main requires.

@github-actions github-actions Bot added the status:needs-triage Not yet triaged. Applied by the issue forms label Oct 15, 2026
@github-actions

Copy link
Copy Markdown

Thanks for this. It is queued rather than ignored.

This pull request does not reference an issue carrying status:accepted, so a maintainer has not looked at it yet and will not until the underlying issue is triaged. Nothing here is rejected. See Current Priority Scope for what the project is working on, and help wanted for work that is already accepted.

If this is an editorial correction, tick that box in the description and this comment stops applying.

Comment thread reference-implementations/agt/packages/guardian/src/audit-to-otlp.ts Dismissed
@github-actions github-actions Bot mentioned this pull request Oct 16, 2026
@rocklambros
rocklambros deployed to board-automation October 16, 2026 04:49 — with GitHub Actions Active
@acs-board-reconciler acs-board-reconciler Bot moved this from Needs triage to In progress in ACS Project Tracker Oct 16, 2026

@afogel afogel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-quality nits on the trace exporter, measured against the rest of the reference implementation. None of them is a bug, and the typing is clean: no any, no bare containers, no @ts- suppressions, and it passes bun run typecheck under the strict config. The exporter follows the envelope-log-sink.ts pattern well (total by construction, null object, test seams). The comments mark where it departs from that pattern.

afogel
afogel previously approved these changes Oct 16, 2026

@afogel afogel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few code quality nits, but lgtm

Comment thread reference-implementations/agt/packages/guardian/src/otel-trace-exporter.ts Outdated
Comment thread reference-implementations/agt/packages/guardian/src/otel-trace-exporter.ts Outdated
Comment thread reference-implementations/agt/packages/guardian/src/otel-trace-exporter.ts Outdated
Comment thread reference-implementations/agt/packages/guardian/src/audit-to-otlp.ts Outdated
Comment thread reference-implementations/agt/packages/guardian/src/otel-trace-exporter.ts Outdated
Comment thread reference-implementations/agt/packages/guardian/src/server.ts Outdated
Refs #274

Signed-off-by: Rock Lambros <rock@rockcyber.com>
@rocklambros

Copy link
Copy Markdown
Collaborator Author

@afogel, your approval was dismissed because your six code-quality comments are now in, as PR #289. That pushed new commits to integration, which is this PR's head. Every comment is addressed, with tests for each, and the trace output is identical to before the change in the end-to-end run. Could you re-approve when you get a minute? That's the last step before 0.1.4 ships.

@rocklambros
rocklambros merged commit 834f3f0 into main Oct 16, 2026
14 of 20 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in ACS Project Tracker Oct 16, 2026
@rocklambros
rocklambros deployed to board-automation October 17, 2026 04:47 — with GitHub Actions Active
@rocklambros
rocklambros deployed to board-automation October 18, 2026 04:48 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
board-automation — 8a459524 Deployed Oct 18, 2026 by rocklambros via reconcile #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:needs-triage Not yet triaged. Applied by the issue forms

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants