Repository navigation
Promote integration to main - #286
Conversation
Signed-off-by: Rock Lambros <rock@rockcyber.com>
Closes #121 Signed-off-by: Rock Lambros <rock@rockcyber.com>
Closes #227 Signed-off-by: Rock Lambros <rock@rockcyber.com>
Closes #91 Signed-off-by: Saba Siddique <sabasiddiqdev@gmail.com> Signed-off-by: Rock Lambros <rock@rockcyber.com>
Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Rock Lambros <rock@rockcyber.com>
|
@afogel @bar-capsule, this is the step that ships 0.1.4, and it needs an approval from one of you. It promotes everything from this week from |
|
Thanks for this. It is queued rather than ignored. This pull request does not reference an issue carrying If this is an editorial correction, tick that box in the description and this comment stops applying. |
afogel
left a comment
There was a problem hiding this comment.
Code-quality nits on the trace exporter, measured against the rest of the reference implementation. None of them is a bug, and the typing is clean: no any, no bare containers, no @ts- suppressions, and it passes bun run typecheck under the strict config. The exporter follows the envelope-log-sink.ts pattern well (total by construction, null object, test seams). The comments mark where it departs from that pattern.
afogel
left a comment
There was a problem hiding this comment.
added a few code quality nits, but lgtm
Refs #274 Signed-off-by: Rock Lambros <rock@rockcyber.com>
|
@afogel, your approval was dismissed because your six code-quality comments are now in, as PR #289. That pushed new commits to |
11 commit(s) ahead. Merging publishes the site and every schema $id URI. Merge with a merge commit, not a squash: squashing flattens the specification history that makes a schema change reviewable later.
What this ships
This is release 0.1.4. Merging it changes
version.txtonmain, sotag-release.ymltagsv0.1.4. The full list is in the 0.1.4 section ofCHANGELOG.md(PR #281).The Trace changes are breaking in principle, while the spec version stays v0.1.0. No producer in this repository is affected, because the reference exporter already conforms and nothing here emits OCSF yet.