Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/templates/result.html
Original file line number Diff line number Diff line change
Expand Up @@ -862,8 +862,8 @@ <h3>📄&nbsp;&nbsp;Raw JSON View</h3>
</div>

<script>
const AIBOM_CDX_JSON_1_6 = {{ aibom_cdx_json_1_6 | safe }};
const AIBOM_CDX_JSON_1_7 = {{ aibom_cdx_json_1_7 | safe }};
const AIBOM_CDX_JSON_1_6 = {{ aibom_cdx_json_1_6 | tojson }};
const AIBOM_CDX_JSON_1_7 = {{ aibom_cdx_json_1_7 | tojson }};
const FILENAME_BASE = "{{ model_id|replace('/', '_') }}";
</script>
<script src="{{ static_root|default('/static') }}/js/script.js"></script>
Expand Down
26 changes: 26 additions & 0 deletions tests/test_web_controller.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import json
import shutil
import tempfile
import unittest
import uuid
from pathlib import Path
Expand Down Expand Up @@ -113,6 +114,31 @@ def get_enhancement_report(self):


class WebControllerTests(unittest.TestCase):
def test_result_template_escapes_json_script_terminators(self):
app = FastAPI()
app.include_router(web_controller.router)
aibom = _sample_aibom()
aibom["components"][0]["description"] = "</script><script>alert(1)</script>"

class MaliciousMetadataService(_FakeService):
def generate_aibom(self, model_id, include_inference=False):
return aibom

with tempfile.TemporaryDirectory() as output_dir:
with patch.object(web_controller, "OUTPUT_DIR", output_dir), \
patch.object(web_controller, "HfApi", _FakeHfApi), \
patch.object(web_controller, "AIBOMService", MaliciousMetadataService), \
patch.object(web_controller, "log_sbom_generation", lambda model_id: None), \
patch.object(web_controller, "get_sbom_count", lambda: "0"):
response = TestClient(app).post(
"/generate",
data={"model_id": "owner/local-web-model"},
)

self.assertEqual(response.status_code, 200)
self.assertNotIn("</script><script>alert(1)</script>", response.text)
self.assertIn(r"\u003c/script\u003e\u003cscript\u003ealert(1)", response.text)

def test_generate_route_writes_utf8_json_to_patched_output_dir(self):
app = FastAPI()
app.include_router(web_controller.router)
Expand Down