Skip to content

fix(api): report project version in status response #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andife wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(api): report project version in status response #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/controllers/web_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from ..models.scoring import calculate_completeness_score
from ..utils.analytics import log_sbom_generation, get_sbom_count
from ..utils.formatter import export_aibom
from ..config import TEMPLATES_DIR, OUTPUT_DIR
from ..config import AIBOM_GEN_VERSION, TEMPLATES_DIR, OUTPUT_DIR

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -56,7 +56,11 @@ async def root(request: Request):

@router.get("/status")
async def get_status():
return {"status": "operational", "version": "1.0.0", "generator_version": "2.0.0"}
return {
"status": "operational",
"version": AIBOM_GEN_VERSION,
"generator_version": AIBOM_GEN_VERSION,
}

@router.post("/generate", response_class=HTMLResponse)
async def generate_form(
Expand Down
16 changes: 16 additions & 0 deletions tests/test_web_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,22 @@ def get_enhancement_report(self):


class WebControllerTests(unittest.TestCase):
def test_status_uses_project_version(self):
app = FastAPI()
app.include_router(web_controller.router)

response = TestClient(app).get("/status")

self.assertEqual(response.status_code, 200)
self.assertEqual(
response.json(),
{
"status": "operational",
"version": web_controller.AIBOM_GEN_VERSION,
"generator_version": web_controller.AIBOM_GEN_VERSION,
},
)

def test_generate_route_writes_utf8_json_to_patched_output_dir(self):
app = FastAPI()
app.include_router(web_controller.router)
Expand Down