refactor: require CI checks and cleanup

.github/workflows/ci.yml

@@ -26,6 +26,8 @@ jobs:
           bun-version-file: package.json
       - run: bun install --frozen-lockfile
       - run: bun run typecheck
+      - run: bun run lint
+      - run: bun run format:check
       - run: bun run build
       - run: bunx playwright install --with-deps chromium
       - run: bun run test:e2e

knip.json

@@ -2,12 +2,12 @@
   "$schema": "https://unpkg.com/knip@6/schema.json",
   "workspaces": {
     ".": {
-      "entry": ["src/index.{js,jsx,ts,tsx}"],
-      "project": ["src/**/*.{js,jsx,ts,tsx}"]
+      "entry": ["src/index.tsx"],
+      "project": ["src/**/*.{ts,tsx}"]
     },
     "sanity": {
-      "entry": ["sanity.config.{js,ts}", "sanity.cli.{js,ts}"],
-      "project": ["**/*.{js,ts}"]
+      "entry": ["sanity.config.ts", "sanity.cli.ts"],
+      "project": ["**/*.ts"]
     }
   },
   "treatTagHintsAsErrors": true,

netlify.toml

@@ -1,2 +1,2 @@
 [build.environment]
-  BUN_VERSION = "1.4.2"
+BUN_VERSION = "1.4.2"

oxlint.config.ts

@@ -26,6 +26,7 @@ export default defineConfig({
     '.roo/**',
     '.windsurf/**',
     'tools/oxlint/anti-slop/**',
+    'sanity/**',
   ],
   jsPlugins: [
     {
@@ -90,7 +91,10 @@ export default defineConfig({
     'unicorn/prefer-spread': 'warn',
     'react/rules-of-hooks': 'error',
     'react/require-render-return': 'error',
-    'react/no-multi-comp': 'error',
+    'react/no-multi-comp': 'off',
+    'react/jsx-key': ['error', { checkFragmentShorthand: true }],
+    'import/no-unassigned-import': ['warn', { allow: ['**/*.css'] }],
+    'jsx-a11y/no-noninteractive-tabindex': ['error', { tags: ['section'] }],
     'react/no-unstable-nested-components': 'error',
     'react/only-export-components': ['error', { allowConstantExport: true }],
     'react-you-might-not-need-an-effect/no-adjust-state-on-prop-change': 'error',
@@ -121,5 +125,11 @@ export default defineConfig({
         'typescript/explicit-function-return-type': 'off',
       },
     },
+    {
+      files: ['src/assets/**/*.tsx', 'src/pages/LandingPageV3/ChooseYourCharacter/Mascot.tsx'],
+      rules: {
+        'eslint/max-lines-per-function': 'off',
+      },
+    },
   ],
 });

public/css/applyPage.css

@@ -15,16 +15,16 @@
 }
 
 .ap_img {
-    background-image: url('/images/applyBackground.JPG');
-    height: 100%;
-    width: 100%;
-    position: fixed;
-    background-color: rgba(0, 0, 0, 0.7);
-    background-position: center;
-    background-repeat: no-repeat;
-    background-size: cover;
-    z-index: -1;
-    filter: brightness(50%);
+  background-image: url('/images/applyBackground.JPG');
+  height: 100%;
+  width: 100%;
+  position: fixed;
+  background-color: rgba(0, 0, 0, 0.7);
+  background-position: center;
+  background-repeat: no-repeat;
+  background-size: cover;
+  z-index: -1;
+  filter: brightness(50%);
 }
 
 .ap_text {

public/css/style.css

@@ -1,78 +1,97 @@
 * {
-    transition-timing-function: ease-in-out;
-    -ms-transition-timing-function: ease-in-out;
-    -moz-transition-timing-function: ease-in-out;
-    -webkit-transition-timing-function: ease-in-out;
-    -o-transition-timing-function: ease-in-out;
-    transition-duration: 0.3s;
-    -ms-transition-duration: 0.3s;
-    -moz-transition-duration: 0.3s;
-    -webkit-transition-duration: 0.3s;
-    -o-transition-duration: 0.3s;
+  transition-timing-function: ease-in-out;
+  -ms-transition-timing-function: ease-in-out;
+  -moz-transition-timing-function: ease-in-out;
+  -webkit-transition-timing-function: ease-in-out;
+  -o-transition-timing-function: ease-in-out;
+  transition-duration: 0.3s;
+  -ms-transition-duration: 0.3s;
+  -moz-transition-duration: 0.3s;
+  -webkit-transition-duration: 0.3s;
+  -o-transition-duration: 0.3s;
 }
 
 @font-face {
-    font-family: "Commuters Sans 800";
-    src: url("https://use.typekit.net/af/e66d72/00000000000000007735c462/30/l?subset_id=2&fvd=n8&v=3") format("woff2"), url("https://use.typekit.net/af/e66d72/00000000000000007735c462/30/d?subset_id=2&fvd=n8&v=3") format("woff"), url("https://use.typekit.net/af/e66d72/00000000000000007735c462/30/a?subset_id=2&fvd=n8&v=3") format("opentype");
-    font-display: auto;
-    font-style: normal;
-    font-weight: 800;
+  font-family: 'Commuters Sans 800';
+  src:
+    url('https://use.typekit.net/af/e66d72/00000000000000007735c462/30/l?subset_id=2&fvd=n8&v=3') format('woff2'),
+    url('https://use.typekit.net/af/e66d72/00000000000000007735c462/30/d?subset_id=2&fvd=n8&v=3') format('woff'),
+    url('https://use.typekit.net/af/e66d72/00000000000000007735c462/30/a?subset_id=2&fvd=n8&v=3') format('opentype');
+  font-display: auto;
+  font-style: normal;
+  font-weight: 800;
 }
 
 @font-face {
-    font-family: "Commuters Sans 700";
-    src: url("https://use.typekit.net/af/857ae9/00000000000000007735c460/30/l?subset_id=2&fvd=n7&v=3") format("woff2"), url("https://use.typekit.net/af/857ae9/00000000000000007735c460/30/d?subset_id=2&fvd=n7&v=3") format("woff"), url("https://use.typekit.net/af/857ae9/00000000000000007735c460/30/a?subset_id=2&fvd=n7&v=3") format("opentype");
-    font-display: auto;
-    font-style: normal;
-    font-weight: 700;
+  font-family: 'Commuters Sans 700';
+  src:
+    url('https://use.typekit.net/af/857ae9/00000000000000007735c460/30/l?subset_id=2&fvd=n7&v=3') format('woff2'),
+    url('https://use.typekit.net/af/857ae9/00000000000000007735c460/30/d?subset_id=2&fvd=n7&v=3') format('woff'),
+    url('https://use.typekit.net/af/857ae9/00000000000000007735c460/30/a?subset_id=2&fvd=n7&v=3') format('opentype');
+  font-display: auto;
+  font-style: normal;
+  font-weight: 700;
 }
 
 @font-face {
-    font-family: "Commuters Sans 600";
-    src: url("https://use.typekit.net/af/857ae9/00000000000000007735c460/30/l?subset_id=2&fvd=n7&v=3") format("woff2"), url("https://use.typekit.net/af/857ae9/00000000000000007735c460/30/d?subset_id=2&fvd=n7&v=3") format("woff"), url("https://use.typekit.net/af/857ae9/00000000000000007735c460/30/a?subset_id=2&fvd=n7&v=3") format("opentype");
-    font-display: auto;
-    font-style: normal;
-    font-weight: 600;
+  font-family: 'Commuters Sans 600';
+  src:
+    url('https://use.typekit.net/af/857ae9/00000000000000007735c460/30/l?subset_id=2&fvd=n7&v=3') format('woff2'),
+    url('https://use.typekit.net/af/857ae9/00000000000000007735c460/30/d?subset_id=2&fvd=n7&v=3') format('woff'),
+    url('https://use.typekit.net/af/857ae9/00000000000000007735c460/30/a?subset_id=2&fvd=n7&v=3') format('opentype');
+  font-display: auto;
+  font-style: normal;
+  font-weight: 600;
 }
 
 @font-face {
-    font-family: 'Space Mono 400';
-    font-style: normal;
-    font-weight: 400;
-    font-display: swap;
-    src: url(https://fonts.gstatic.com/s/spacemono/v6/i7dNIFZifjKcF5UAWdDRYERMR3K_MQacbw.woff2) format('woff2');
-    unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
+  font-family: 'Space Mono 400';
+  font-style: normal;
+  font-weight: 400;
+  font-display: swap;
+  src: url(https://fonts.gstatic.com/s/spacemono/v6/i7dNIFZifjKcF5UAWdDRYERMR3K_MQacbw.woff2) format('woff2');
+  unicode-range:
+    U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2122, U+2191,
+    U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
 }
 
 @font-face {
-    font-family: 'Space Mono 700';
-    font-style: normal;
-    font-weight: 700;
-    src: url(https://fonts.gstatic.com/s/spacemono/v10/i7dMIFZifjKcF5UAWdDRaPpZUFWaHi6WZ3Q.woff2) format('woff2');
-    unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
-  }
+  font-family: 'Space Mono 700';
+  font-style: normal;
+  font-weight: 700;
+  src: url(https://fonts.gstatic.com/s/spacemono/v10/i7dMIFZifjKcF5UAWdDRaPpZUFWaHi6WZ3Q.woff2) format('woff2');
+  unicode-range:
+    U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2122, U+2191,
+    U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
+}
 
-  @font-face {
-    font-family: 'Outfit 300';
-    font-style: normal;
-    font-weight: 300;
-    src: url(https://fonts.gstatic.com/s/outfit/v4/QGYyz_MVcBeNP4NjuGObqx1XmO1I4W61O4a0FQItq6fNIg.woff) format('woff');
-    unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
-  }
+@font-face {
+  font-family: 'Outfit 300';
+  font-style: normal;
+  font-weight: 300;
+  src: url(https://fonts.gstatic.com/s/outfit/v4/QGYyz_MVcBeNP4NjuGObqx1XmO1I4W61O4a0FQItq6fNIg.woff) format('woff');
+  unicode-range:
+    U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2122, U+2191,
+    U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
+}
 
 @font-face {
-    font-family: 'Outfit 400';
-    font-style: normal;
-    font-weight: 400;
-    font-display: swap;
-    src: url(https://fonts.gstatic.com/s/outfit/v2/QGYyz_MVcBeNP4NjuGObqx1XmO1I4TC1O4a0FQItq6fNIg.woff) format('woff');
-    unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
+  font-family: 'Outfit 400';
+  font-style: normal;
+  font-weight: 400;
+  font-display: swap;
+  src: url(https://fonts.gstatic.com/s/outfit/v2/QGYyz_MVcBeNP4NjuGObqx1XmO1I4TC1O4a0FQItq6fNIg.woff) format('woff');
+  unicode-range:
+    U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2122, U+2191,
+    U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
 }
 
 @font-face {
-    font-family: 'Outfit 600';
-    font-style: normal;
-    font-weight: 600;
-    src: url(https://fonts.gstatic.com/s/outfit/v4/QGYyz_MVcBeNP4NjuGObqx1XmO1I4e6yO4a0FQItq6fNIg.woff) format('woff');
-    unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
-  }
+  font-family: 'Outfit 600';
+  font-style: normal;
+  font-weight: 600;
+  src: url(https://fonts.gstatic.com/s/outfit/v4/QGYyz_MVcBeNP4NjuGObqx1XmO1I4e6yO4a0FQItq6fNIg.woff) format('woff');
+  unicode-range:
+    U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2122, U+2191,
+    U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
+}

sanity/package.json

@@ -1,9 +1,12 @@
 {
   "name": "generate-sanity",
-  "private": true,
   "version": "1.0.0",
-  "main": "package.json",
+  "private": true,
+  "keywords": [
+    "sanity"
+  ],
   "license": "UNLICENSED",
+  "main": "package.json",
   "scripts": {
     "dev": "sanity dev",
     "start": "sanity start",
@@ -12,9 +15,6 @@
     "deploy-graphql": "sanity graphql deploy",
     "typecheck": "tsc"
   },
-  "keywords": [
-    "sanity"
-  ],
   "dependencies": {
     "@sanity/cli": "^8.2.1",
     "@sanity/color-input": "^6.1.4",
@@ -32,9 +32,9 @@
     "typescript": "^7.0.2"
   },
   "prettier": {
-    "semi": false,
-    "printWidth": 100,
     "bracketSpacing": false,
+    "printWidth": 100,
+    "semi": false,
     "singleQuote": true
   }
 }