Repository navigation
feat(installer): unsigned double-click installers attached to every release - #1975
Merged
Merged
Conversation
…macOS, Windows and Linux
…ith the verified tag
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (7)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1700
Summary
A person who does not use a terminal can now install Gentle Shell like a classic desktop installer: download one file, double-click it, follow the steps in the browser.
releases/latest/download/<name>):gentle-shell-installer-macos.zip(Install Gentle Shell.command),gentle-shell-installer-windows.zip(Install Gentle Shell.cmd) andgentle-shell-installer-linux.tar.gz(install-gentle-shell.sh), plusgentle-shell-installers-SHA256SUMS.txt.node:modules).Changes
scripts/build-installer-bundles.mjs.cmd), archives, checksums. Launchers report a failed bootstrap..github/workflows/publish.ymlinstallersjob:needs: publish, same verified commit (github.sha),persist-credentials: false,contents: writeonly here, uploads with the publish job's verified tag (needs.publish.outputs.tag),--clobber. npm publication is unaffected by its failure.README.md,docs/install-wizard.mdgh run rerun <id> --failed).tests/installer-bundles.test.ts,tests/package-manifest.test.tsTest plan
tests/installer-bundles.test.ts tests/package-manifest.test.ts tests/verify-package-files.test.ts: 78 pass, 0 fail.pnpm run typecheck: no regressions. Fullpnpm test: only the three failures already onmain.dittokeepsInstall Gentle Shell.commandexecutable;sh -non the launcher passes.ac91c0b24(after the reviewed candidate).actionlint: not available locally.Summary by CodeRabbit