Safeguard all call class's public methods against NPE - #1758
Closed
rahul-lohra wants to merge 3 commits into
Closed
Conversation
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
PratimMallick
approved these changes
Aug 4, 2026
…eam/stream-video-android into improvement/rahullohra/wrap-npe-on-decomposed-call # Conflicts: # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/Call.kt
|
Contributor
Author
|
Closing this PR — the NPE crash is already resolved in #1740, released in v1.29.0. Note on reproducing the exact stack trace The reported message only appears on a release build with AGP 9+: Why: |
An error occurred while trying to automatically change base from
refactor/call-class-decomposition
to
develop
August 5, 2026 08:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Goal
Closes #AND-1350
We got a crash with stacktrace
Since we were unable to reproduce the crash with the exact stack trace, we decided to defensively guard all public methods of the Call class against potential
NullPointerExceptions.Implementation
Wrap all
Callclass's public method which returnsResultwithtry-catch🎨 UI Changes
None
Testing
Smoke test video/audio call