Skip to content

workflows: Collect every bounded closing Issue - #20

Merged
idy merged 1 commit into
mainfrom
codex/fix-closing-issue-pagination
Aug 3, 2026
Merged

workflows: Collect every bounded closing Issue#20
idy merged 1 commit into
mainfrom
codex/fix-closing-issue-pagination

Conversation

@idy

@idy idy commented Aug 3, 2026

Copy link
Copy Markdown
Member

Summary

  • collect the complete bounded 100-node closingIssuesReferences page in both review-context capture and final snapshot verification
  • remove the second ten-Issue truncation while preserving the existing fail-closed count check
  • add regression coverage for a tracker with 31 children and document the supported bound

Root cause

The reviewer requested only 20 native closing Issues and then retained only 10. Pull requests such as GizClaw/gizclaw#758, with one tracker and 31 implementation children, therefore received false too-many-closing-issues and missing-open-sub-issues blockers even though GitHub contained all native relationships.

Validation

  • node .github/scripts/issue-review/test.mjs
  • node .github/scripts/pr-readiness/test.mjs
  • node .github/scripts/pr-review/test.mjs
  • node --check .github/scripts/pr-readiness/test.mjs
  • node --check .github/scripts/pr-readiness/verify.mjs
  • git diff --check

Closes #19

Large tracking pull requests were falsely blocked because the reviewer fetched
twenty native closing Issues and retained only ten, while GitHub reported the
complete relationship count.

- Collect and verify up to GitHub's full 100-node closing-Issue page
- Preserve fail-closed behavior when relationship or sub-issue evidence exceeds the bound
- Cover a 32-Issue tracker and the former first-ten truncation boundary
- Document the complete bounded collection contract

Generated with [Codex](https://github.com/openai)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ OpenAI PR Review: PASS

Conclusion: Ready from the OpenAI review perspective. PR format, linked Issue design, and code/plan conformance passed with no actionable findings.

Review checks

Check Result
PR format ✅ PASS
Issue design ✅ PASS
Code & plan conformance ✅ PASS

Scope: ca14dfc9ef · a98c71294d..ca14dfc9ef · full · 1 diff chunk

Usage: 43s · 236,055 tokens · 78.7% cache hit · 5.460 credits

Summary

Aggregated the sole completed chunk review. No duplicate, prior, or plan-conformance findings apply to the complete PR state.

Review metadata
  • Commit: ca14dfc9ef
  • Range: a98c71294d..ca14dfc9ef
  • Mode: full
  • Diff chunks: 1
  • Model: gpt-5.6-terra
  • Reasoning effort: medium
  • Session: repo-1309321116-pr-20-v2
  • Generation: b3a31ca4b6e33265537fcc596e73f8182b0c17dd36bc1ab1d06c258ed5b072a9
  • Evidence: 021cb28517d097055f03dd78fe8335e134cc1b382c98dbd80205542e340b9670

Totals

  • Input: 232,801
  • Cached input: 183,286
  • Cache write: 49,479
  • Output: 3,254
  • Reasoning: 1,383
  • Total: 236,055
  • Estimated credits: 5.460
  • Credit rate per 1M tokens: 62.5 input / 6.25 cached / 375 output
Token and cache details
Stage Mode Target Time Input Cached Hit Output Total Credits
pr deterministic format rules 0s 0 0 0.0% 0 0 0.000
pr full pr 8s 19,271 9,273 48.1% 310 19,581 0.799
issue full Issue #19 13s 55,890 47,508 85.0% 1,143 57,033 1.249
code full chunk 1/1 19s 96,905 67,786 70.0% 1,562 98,467 2.829
code full aggregate 3s 60,735 58,719 96.7% 239 60,974 0.583

@idy
idy merged commit 186e83c into main Aug 3, 2026
11 checks passed
@idy
idy deleted the codex/fix-closing-issue-pagination branch August 3, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: Collect every bounded native closing Issue

1 participant