workflows: Snapshot native Issue dependencies - #22
Merged
Conversation
Issue Review omitted GitHub's native dependency connections, so reviewers could not verify real blocked-by ordering and readiness could remain unchanged when those relationships changed. - Capture bounded blockedBy and blocking connections in review and verification queries - Normalize, deduplicate, sort, hash, and fail closed on incomplete dependencies - Upgrade the Issue snapshot schema and cover live identity-changing boundaries Generated with [Codex](https://github.com/openai)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ OpenAI PR Review: PASS
Conclusion: Ready from the OpenAI review perspective. PR format, linked Issue design, and code/plan conformance passed with no actionable findings.
Review checks
| Check | Result |
|---|---|
| PR format | ✅ PASS |
| Issue design | ✅ PASS |
| Code & plan conformance | ✅ PASS |
Scope: 2a3e3b377c · 186e83c1a0..2a3e3b377c · full · 1 diff chunk
Usage: 43s · 263,658 tokens · 76.5% cache hit · 6.261 credits
Summary
All completed code chunks are consistent with Issue #21’s plan. No actionable findings or plan-conformance blockers remain.
Review metadata
- Commit:
2a3e3b377c - Range:
186e83c1a0..2a3e3b377c - Mode:
full - Diff chunks:
1 - Model:
gpt-5.6-terra - Reasoning effort:
medium - Session:
repo-1309321116-pr-22-v2 - Generation:
a5f4b3c4a2b97066ad3d505bbc05157e6ce4c8fecd70d8b491adce08b377fce1 - Evidence:
d1a851b27c4517542f7d60bdf50bc6f007c406d5151868c9becbace148b66e92
Totals
- Input:
260,499 - Cached input:
199,200 - Cache write:
61,263 - Output:
3,159 - Reasoning:
1,604 - Total:
263,658 - Estimated credits:
6.261 - Credit rate per 1M tokens:
62.5input /6.25cached /375output
Token and cache details
| Stage | Mode | Target | Time | Input | Cached | Hit | Output | Total | Credits |
|---|---|---|---|---|---|---|---|---|---|
pr |
deterministic |
format rules |
0s | 0 | 0 | 0.0% | 0 | 0 | 0.000 |
pr |
full |
pr |
5s | 19,432 | 9,275 | 47.7% | 276 | 19,708 | 0.796 |
issue |
full |
Issue #21 |
17s | 84,359 | 68,818 | 81.6% | 1,465 | 85,824 | 1.951 |
code |
full |
chunk 1/1 |
17s | 87,300 | 54,604 | 62.5% | 1,204 | 88,504 | 2.836 |
code |
full |
aggregate |
4s | 69,408 | 66,503 | 95.8% | 214 | 69,622 | 0.677 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blockedByandblockingrelationship for each closing Issue in both review-context capture and publication-time verificationLive acceptance evidence
The updated local snapshot mapper was exercised against the current GraphQL state of
h2vivi/firmwares#654and captured:No dependency connection was truncated in that live snapshot.
Validation
node .github/scripts/issue-review/test.mjsnode .github/scripts/pr-readiness/test.mjsnode .github/scripts/pr-review/test.mjsnode --check .github/scripts/issue-review/common.mjsnode --check .github/scripts/pr-readiness/verify.mjsruby -e 'require "yaml"; YAML.load_file(".github/workflows/codex-openai-review.yml")'git diff --checkh2vivi/firmwares#654GraphQL query plus local schema-v4 mapping assertionactionlintreports the same six existingjob.workflow_repository/job.workflow_shacontext diagnostics on both the base workflow and this branch; this change adds no new diagnostic.Closes #21