docs: add disabling monitoring guide and benchmark report - #2244
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| When `DISABLE_MONITORING=true` is injected: | ||
| - The `reconciler-manager` skips registering Otel controllers. | ||
| - Reconciler Pods will no longer include `otel-agent` sidecar containers. | ||
| - Metric recording calls fallback safely to OpenTelemetry Noop providers without panic or network connection errors. |
There was a problem hiding this comment.
I feel this section is too detail in technical side, can be removed.
| value: "true" | ||
| ``` | ||
|
|
||
| 2. Delete the monitoring namespace: |
There was a problem hiding this comment.
Recommend noting the users to confirm all the syncs are configured to disable monitoring before this step
|
|
||
| ```yaml | ||
| env: | ||
| - name: DISABLE_MONITORING |
There was a problem hiding this comment.
It'd be convenient if provide a kubectl command for both controllers
| apiVersion: configsync.gke.io/v1beta1 | ||
| kind: RootSync | ||
| metadata: | ||
| name: root-sync |
There was a problem hiding this comment.
Convert the root-sync to a rootsync name placeholder. Same for the namespace - some reposync might not be in this namespace.
2 participants
No description provided.