Fix some skilling bugs

[GregHib]

• Creating sapphire, holy and unholy amulets
• Black warlocks
• Fletching arrow shafts from different log types
• Resetting slayer streaks
• Stop taverley laundry npc from turning when talking Taverly Laundry NPC #1127
• Fix spinning wheel closes Spinning wheel - Crafting Bow String broken in the interface #1125
• Add waterpumps
• Fix watering can on other objects giving messages
• Add restore potion to Bob barters decanting
• Add missing antifire potion decanting

[github-actions]

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[codecov]

Codecov Report

❌ Patch coverage is 33.33333% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.08%. Comparing base (13f697f) to head (9eb9ed5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...tlin/content/entity/player/inv/item/ItemOnItems.kt	0.00%	4 Missing ⚠️
.../kotlin/content/skill/farming/FarmingPatchTreat.kt	0.00%	3 Missing and 1 partial ⚠️
...kotlin/content/skill/fletching/FletchUnfinished.kt	50.00%	0 Missing and 3 partials ⚠️
...kotlin/content/skill/slayer/master/SlayerMaster.kt	0.00%	2 Missing ⚠️
...ain/kotlin/content/skill/crafting/SpinningWheel.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
...misthalin/varrock/grand_exchange/BobBarterHerbs.kt	64.70% <100.00%> (+0.34%)	⬆️
...e/src/main/kotlin/content/skill/cooking/Filling.kt	30.00% <100.00%> (ø)
.../src/main/kotlin/content/skill/hunter/Butterfly.kt	70.58% <100.00%> (ø)
...ain/kotlin/content/skill/crafting/SpinningWheel.kt	55.84% <0.00%> (+0.71%)	⬆️
...kotlin/content/skill/slayer/master/SlayerMaster.kt	8.42% <0.00%> (-0.19%)	⬇️
...kotlin/content/skill/fletching/FletchUnfinished.kt	73.46% <50.00%> (-1.00%)	⬇️
...tlin/content/entity/player/inv/item/ItemOnItems.kt	50.44% <0.00%> (-0.91%)	⬇️
.../kotlin/content/skill/farming/FarmingPatchTreat.kt	55.12% <0.00%> (-2.98%)	⬇️

... and 2 files with indirect coverage changes

@@             Coverage Diff              @@
##               main    #1133      +/-   ##
============================================
- Coverage     44.08%   44.08%   -0.01%     
  Complexity     9804     9804              
============================================
  Files          1962     1962              
  Lines         84797    84805       +8     
  Branches      14013    14018       +5     
============================================
+ Hits          37383    37384       +1     
- Misses        42016    42021       +5     
- Partials       5398     5400       +2     

Components	Coverage Δ
Content	44.54% <33.33%> (-0.01%)	⬇️
Engine	45.55% <ø> (ø)
Network	71.36% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.