fedora 21: grive compilation fails

[jakkul]

Standard grive cannot find json-c libraries.

Solution:

cmake/Modules/FindJSONC.cmake change lines:

FIND_PATH(JSONC_INCLUDE_DIR json-c/json.h)
FIND_LIBRARY(JSONC_LIBRARY NAMES json-c)

You also need to update the include statements in .cc files in code.

[lucquera]

I change the lines in FindJSONC.cmake, but compilation still fails. A lot of messages like this:

CMakeFiles/grive_executable.dir/src/main.cc.o: In function Main(int, char**)': main.cc:(.text+0xe9a): undefined reference togr::Json::Jsonstd::string(std::string const&)'

I need uptade te .cc files? how can I do it?

[jakkul]

this is something different. Are you using fedora 21? Have you followed each installation step from the manual? What errors did you get before you've started modyfying the source yourself?

[lucquera]

I'm using fedora 21, 32bits. I reinstalled in another folder, and i get the same error: could not find json-c. I changed the lines in cmake/Modules/FindJSONC.cmake, and the "cmake ." command works sucessfully. Then, another error in "make" command. Stops on 40% then shows:
/home/lucaslazarini/Downloads/grive-0.2.0/libgrive/src/protocol/Json.cc:24:31: fatal error: json/json_tokener.h: Arquivo ou diretório não encontrado
#include < json/json_tokener.h >

compilation terminated.
libgrive/CMakeFiles/grive.dir/build.make:353: recipe for target 'libgrive/CMakeFiles/grive.dir/src/protocol/Json.cc.o' failed
make[2]: *** [libgrive/CMakeFiles/grive.dir/src/protocol/Json.cc.o] Error 1
CMakeFiles/Makefile2:75: recipe for target 'libgrive/CMakeFiles/grive.dir/all' failed
make[1]: *** [libgrive/CMakeFiles/grive.dir/all] Error 2
Makefile:117: recipe for target 'all' failed
make: *** [all] Error 2

[elken]

Managed to fix with #292 for me, so try that.

[lucquera]

everything runs ok, until 89%:

[ 89%] Building CXX object grive/CMakeFiles/grive_executable.dir/src/main.cc.o
Linking CXX executable grive
../libgrive/libgrive.a(State.cc.o): In function gr::v1::State::Write(boost::filesystem::path const&) const': State.cc:(.text+0x190a): undefined reference togr::Json::Json(long const&)'
State.cc:(.text+0x199d): undefined reference to gr::Json::Json<unsigned long>(unsigned long const&)' State.cc:(.text+0x1a89): undefined reference togr::Json::Json(long const&)'
collect2: error: ld returned 1 exit status
grive/CMakeFiles/grive_executable.dir/build.make:102: recipe for target 'grive/grive' failed
make[2]: *** [grive/grive] Error 1
CMakeFiles/Makefile2:162: recipe for target 'grive/CMakeFiles/grive_executable.dir/all' failed
make[1]: *** [grive/CMakeFiles/grive_executable.dir/all] Error 2
Makefile:117: recipe for target 'all' failed
make: *** [all] Error 2

[elken]

Have you tried a full recompilation? And can you verify you actually have both json-c and json-c-devel installed?

[lucquera]

I started from the begining, and I checked, and json-c-0.12-5.fc21.i686 and json-c-devel-0.12-5.fc21.i686 are installed.

[elken]

Is the json.h file located under /usr/include/json-c/json.h? If it is
then everything should be working fine. :/

[lucquera]

Yes, json.h file is located in there. Tried again as root and got the same error with this State.cc.o file. Don't know why compilation fails :/

[lucquera]

fixed with #193. It seems a problem with 32bit

[elken]

I figured it was, was going to dive through the code later but glad you
sorted :)

[rseward]

My compile breaks with a similar problem. Fedora 20 64 bit with the following json-c deps installed.

json-c-0.11-6.fc20.i686
json-c-devel-0.11-6.fc20.x86_64
json-c-0.11-6.fc20.x86_64

[ 89%] Building CXX object grive/CMakeFiles/grive_executable.dir/src/main.cc.o
Linking CXX executable grive
/bin/ld: ../libgrive/libgrive.a(Json.cc.o): undefined reference to symbol 'json_object_array_get_idx'
/bin/ld: note: 'json_object_array_get_idx' is defined in DSO /lib64/libjson-c.so.2 so try adding it to the linker command line
/lib64/libjson-c.so.2: could not read symbols: Invalid operation
collect2: error: ld returned 1 exit status
make[2]: *** [grive/grive] Error 1
make[1]: *** [grive/CMakeFiles/grive_executable.dir/all] Error 2
make: *** [all] Error 2

I used to write C++ about 10 years ago. But I am a bit lost with the slick new tools (cmake, etc.). Suggestions for fixing the linker line would be appreciated. I can retry the build on a Fedora 21 64 bit machine I have if that helps.

[lucquera]

I got this error too. #292 fixed too me. Have you tried?

[elken]

It looks like a gcc problem, gcc can't find the library for some reason.
Try adding it to CMAKE_CXX_FLAGS.

[pro-a-v]

in cmake/Modules/FindJSONC.cmake

SET(JSONC_INCLUDE_DIR /usr/include/json-c/)
SET(JSONC_LIBRARY json-c)
SET(JSONC_FOUND TRUE)

IF (JSONC_FOUND)

in /libgrive/src/protocol/Json.cc

#include ...json_tokener.h //was json change to json-c
#include ...linkhash.h //was json change to json-c

in 380 str in file some rude but works:
if ( json == 0 )
BOOST_THROW_EXCEPTION( Error() << expt::ErrMsg( "ParseFile error" ) ) ;

DONE.
cmake
make make install