Skip to content

OSC 52 protocol implementation #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bitifet wants to merge 2 commits into
base: master
Choose a base branch
from
+660 −4
Open

OSC 52 protocol implementation #2333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe7d8cd
Implement OSC 52 clipboard protocol via PTY proxy
Copilot Jul 18, 2026
3e24e74
Address code review: fix EOF busy loop, false-positive buffering, err…
Copilot Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions guake/data/org.guake.gschema.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,11 @@
<summary>Copy selected text if enabled.</summary>
<description>Copy the selected text.</description>
</key>
<key name="enable-osc52" type="b">
<default>true</default>
<summary>Enable OSC 52 clipboard access</summary>
<description>Allow applications running in the terminal to set the system clipboard using the OSC 52 escape sequence.</description>
</key>
</schema>
<schema id="guake.style" path="/org/guake/style/">
<key name="cursor-blink-mode" type="i">
Expand Down
15 changes: 15 additions & 0 deletions guake/data/prefs.glade
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,21 @@
<property name="top-attach">4</property>
</packing>
</child>
<child>
<object class="GtkCheckButton" id="enable_osc52">
<property name="label" translatable="yes">Enable OSC 52 clipboard access</property>
<property name="visible">True</property>
<property name="can-focus">True</property>
<property name="receives-default">False</property>
<property name="halign">start</property>
<property name="draw-indicator">True</property>
<signal name="toggled" handler="on_enable_osc52_toggled" swapped="no"/>
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">5</property>
</packing>
</child>
<child>
<placeholder/>
</child>
Expand Down
8 changes: 8 additions & 0 deletions guake/prefs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,10 @@ def on_copy_on_select_toggled(self, chk):
"""Changes the value of copy_on_select in dconf"""
self.settings.general.set_boolean("copy-on-select", chk.get_active())

def on_enable_osc52_toggled(self, chk):
"""Changes the value of enable_osc52 in dconf"""
self.settings.general.set_boolean("enable-osc52", chk.get_active())

def on_tab_name_display_changed(self, combo):
"""Save `display-tab-names` property value in dconf"""
self.settings.general.set_int("display-tab-names", combo.get_active())
Expand Down Expand Up @@ -1274,6 +1278,10 @@ def load_configs(self):
value = self.settings.general.get_boolean("copy-on-select")
self.get_widget("copy_on_select").set_active(value)

# enable osc52
value = self.settings.general.get_boolean("enable-osc52")
self.get_widget("enable_osc52").set_active(value)

# font
value = self.settings.styleFont.get_string("style")
if value:
Expand Down
Loading