Repository navigation
Consolidate Kirshara protections under one default-on option - #367
Open
Guffawaffle wants to merge 3 commits into
Open
Guffawaffle wants to merge 3 commits into
Guffawaffle wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kirshara protections now share one default-on
[control] kirshara_fixessetting. Mod Settings → Map & Travel → Kirshara queue fixes controls every supported protection and saves the canonical key; the retired individual keys are ignored. The queue hotkey and live toggle forget only mod response tracking, preserving native queued targets. Independent hook compatibility switches remain available.Imports the focused consolidation from upstream PR #287 while retaining the fork's existing Windows/macOS adapters. Updates the English example and Mac test instructions, and covers false/true disk persistence with a fresh parse.
Validation: three queue suites, config-save/writer/adapter and disk/reload fixtures, TOML parsing and diff checks pass. Local Windows release build passes. This candidate has not been deployed; fresh gameplay and current Mac native fit/runtime remain unverified.