Repository navigation
Conversation
On OpenBSD 7.9 arm64 (clang), test_basic_io() had a 21824-byte stack frame, over the -Wframe-larger-than=16384 limit. Split its tests 7-10 into a new test_basic_io_2() and make the large int buffers static so each function's stack frame stays well under the limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hyoklee
requested review from
fortnern,
glennsong09,
jhendersonHDF,
mattjala and
vchoi-hdfgroup
as code owners
October 14, 2026 18:09
github-actions
Bot
removed request for
fortnern,
jhendersonHDF,
mattjala and
vchoi-hdfgroup
October 14, 2026 18:11
Contributor
Review ChecklistThis PR touches the following areas. Each needs a sign-off
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes the
-Wframe-larger-than=16384warning fortest_basic_io()intest/vds.con OpenBSD 7.9 arm64 (clang):stack frame size (21824) exceeds limit (16384).test_basic_io()into a newtest_basic_io_2(), whichmain()calls right aftertest_basic_io(). The new function sets up its own filenames and DCPL (with the same fill value) and has its own cleanup.intbuffers in both functionsstatic. This alone only brought the frame down to 17184 bytes, so the split is also needed.Verified with a build-only OpenBSD 7.9 arm64 job (cross-platform-actions), which built
vdswith no warnings: https://github.com/hyoklee/hdf5/actions/runs/38480526693. Locally (gcc, Linux), thevdstest passes and the file is formatted with clang-format 17.Issue ticket number (GitHub or JIRA)
Fixes #6736
Checklist before requesting a review
🤖 Generated with Claude Code