Repository navigation
Conversation
Update workflows to build and publish Windows MSVC S3 and macOS Clang S3 binaries.
The test-jni-package job expanded \ in its settings.xml heredoc without defining it, producing an empty <url> and causing Maven to fail with 'repository.url ... is missing'. The FFM job already sets it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lrknox
requested review from
glennsong09,
hyoklee,
jhendersonHDF and
mattjala
as code owners
October 19, 2026 02:44
Contributor
Review ChecklistThis PR touches the following areas. Each needs a sign-off
Additional reviewers (not owners of a touched area): @ajelenak |
lrknox
marked this pull request as draft
October 19, 2026 15:36
| KEYCHAIN_NAME: ${{ vars.KEYCHAIN_NAME }} | ||
| SIGNER: ${{ vars.SIGNER }} | ||
| NOTARY_USER: ${{ vars.NOTARY_USER }} | ||
| NOTARY_KEY: ${{ vars.NOTARY_KEY }} |
Collaborator
There was a problem hiding this comment.
Isn't this the same issue as in HDFView? secrets instead of vars here and several places below
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed #5907.
Added 3 presets to CMakePresets.json and jobs to ctest.yml to create release binaries with ros3 enabled:
ci-StdShar-macos-Clang-s3 (arm64)
ci-StdShar-macos-x86_64-Clang-S3
ci-StdShar-MSVC-S3
Added install/build as needed for aws-c-s3 on Windows and macos.
Updated macos15 to macos26 for release workflow to match macos-latest used in most workflows.
Initial test release binaries at https://github.com/lrknox/hdf5/releases/tag/untagged-0d5274ce7f78584cd530.