Repository navigation
Fix ROS3 VFD feature flag check in vfd test - #6770
Merged
Merged
Conversation
The thread-safe filters change (HDFGroup#6710) made the ROS3 VFD report H5FD_FEAT_READWRITE_NO_H5_CALLS from its query callback and updated the sec2, core, log and windows driver checks in test/vfd.c accordingly, but test_ros3() still expected H5FD_FEAT_DATA_SIEVE to be the only flag, so the vfd test failed on any build with the ROS3 VFD enabled. Expect both flags in test_ros3(), matching test/ros3.c. Co-Authored-By: Claude Mythos 5.1 <noreply@anthropic.com>
hyoklee
requested review from
fortnern,
glennsong09,
jhendersonHDF,
mattjala and
vchoi-hdfgroup
as code owners
October 22, 2026 12:44
github-actions
Bot
removed request for
fortnern,
glennsong09,
jhendersonHDF and
vchoi-hdfgroup
October 22, 2026 12:45
Contributor
Review ChecklistThis PR touches the following areas. Each needs a sign-off
|
mattjala
approved these changes
Oct 23, 2026
github-project-automation
Bot
moved this from To be triaged
to Done
in HDF5 - TRIAGE & TRACK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
The thread-safe filters change (#6710) made
H5FD__ros3_query()reportH5FD_FEAT_READWRITE_NO_H5_CALLSand updated the sec2, core, log and windows checks intest/vfd.c, buttest_ros3()still expectedH5FD_FEAT_DATA_SIEVEto be the only flag, so thevfdtest fails on any build with the ROS3 VFD enabled.This expects both flags in
test_ros3(), matching the other driver checks intest/vfd.candtest_ros3_fapl_driver_flags()intest/ros3.c.Verified with a Windows / icx 2026.1.1 / Intel MPI build with
HDF5_ENABLE_ROS3_VFD=ON:H5TEST-vfdnow passes.Issue ticket number (GitHub or JIRA)
Fixes #6769
Checklist before requesting a review
🤖 Generated with Claude Code