Repository navigation
Conversation
The two parameter-length checks in H5Z__nbit_decompress() start at index 0, where H5Z_NBIT_PARMS_AVAIL reduces to parms_nelmts >= n plus an always-true unsigned compare (-Wtype-limits). Compare directly instead. Fixes HDFGroup#6772 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
hyoklee
requested review from
fortnern,
glennsong09,
jhendersonHDF,
mattjala and
vchoi-hdfgroup
as code owners
October 22, 2026 18:10
github-actions
Bot
removed request for
fortnern,
glennsong09,
jhendersonHDF and
vchoi-hdfgroup
October 22, 2026 18:38
Contributor
Review ChecklistThis PR touches the following areas. Each needs a sign-off
Additional reviewers (not owners of a touched area): @bmribler |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6772
The two parameter-length checks in
H5Z__nbit_decompress()start at index 0, whereH5Z_NBIT_PARMS_AVAIL(0, n, parms_nelmts)reduces toparms_nelmts >= nplus an always-true unsigned comparison, which GCC reports with-Wtype-limits. These two checks now compareparms_nelmtsdirectly. Behavior is unchanged.Tested: the library builds without the warning with GCC on Linux, and the
dsetstests (which cover the nbit filter) pass.🤖 Generated with Claude Code