Repository navigation
fix logic risk errors in raft.go - #258
Merged
Merged
Conversation
add raft_test for package raft
hu-qing-hua
force-pushed
the
feature/fixRaftModule
branch
from
September 9, 2025 14:36
f15e863 to
754aa1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复问题如下：
1.BootstrapCluster等待成为leader循环没有超时机制，有可能发生一直阻塞
2.完成作者的todo,判断当前create raft dir 是否成功
3. 在cluster core.go里用到err := cluster.raftNode.Close()
if err != nil {
panic(err)
}
但是当前raft的Close实现返回内容为fmt.Errorf("raft shutdown %v", future.Error())，永远不可能判断nil成功
4.增加raft_test.go文件用作测试