Update README.md about eedE - #198

Merged

michmx merged 9 commits into

HEP-FCC:mainfrom

apausa:document-eede

Sep 15, 2026

apausa commented Aug 31, 2026 •

edited

Loading

Member

Update README.md with information about the new features and functionalities.
Replace images with the current interface.
Add image showing filtered out particles.

apausa marked this pull request as draft

August 31, 2026 14:57

apausa changed the title ~~Update README.md for eedE~~ Update README.md about eedE

kjvbrt reviewed

View reviewed changes

2-gen-and-fastsim/2-4-eedE/README.md Outdated

kjvbrt reviewed

View reviewed changes

2-gen-and-fastsim/2-4-eedE/README.md Outdated

kjvbrt reviewed

View reviewed changes

2-gen-and-fastsim/2-4-eedE/README.md Outdated

kjvbrt reviewed

View reviewed changes

2-gen-and-fastsim/2-4-eedE/README.md Outdated

apausa marked this pull request as ready for review

September 1, 2026 13:38

michmx approved these changes

View reviewed changes

michmx left a comment •

edited

Loading

Collaborator

Thanks a lot for this update! I could follow it easily.

I am just leaving a couple of suggestions. And let's wait for @kjvbrt to give the green light after addressing his comments.

2-gen-and-fastsim/2-4-eedE/README.md Outdated

michmx requested a review from kjvbrt

September 3, 2026 19:58

kjvbrt reviewed

View reviewed changes

2-gen-and-fastsim/2-4-eedE/README.md

apausa force-pushed the document-eede branch from b2998df to 062d349 Compare

September 7, 2026 09:34

apausa commented Sep 9, 2026

Member Author

Hi @michmx, the tests are not being ran, can you please take a look at the GitHub Action? I believe the nightly stack should be sourced with --spack. Thank you

michmx commented Sep 15, 2026

Collaborator

Hi @apausa . Sorry for the late reply. Addresing the issue at #202.

(It is related to key4hep/key4hep-images#32)

apausa and others added 9 commits

September 15, 2026 11:28


          Update README.md

09ab272


          Replace images

d0414f6


          Post filtering example image

3a3e49d


          Update README.md with information on new features and functionalities

ea72c51


          Fix symbols

c48c214


          Make changes based on PR feedback

076761b


          Remove dot

5ea9ba4


          Update 2-gen-and-fastsim/2-4-eedE/README.md

71cf2ff

Co-authored-by: Michel H. Villanueva <michel.hernandez.mx@gmail.com>


          Replace subtitle with warning

41704f7

apausa force-pushed the document-eede branch from 062d349 to 41704f7 Compare

September 15, 2026 09:28

apausa commented Sep 15, 2026

Member Author

Hi @michmx, just force-pushed. This can be merged, as well as #201. Thank you!

michmx merged commit f3c819b into HEP-FCC:main

2 checks passed

apausa deleted the document-eede branch

September 21, 2026 10:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet