perf(actions): use cnode and O(1) parent checks in chawathe edit script generator - #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GenerateEditScriptwas cloning full 12-fieldASTNodetrees during edit script generation, so it was creating heavy memory allocations and constant double-map lookups between copies and originals.slices.Contains(x.Children, dst)checks on every candidate pair, so alignment turned into anWhat Changed
ASTNodetree copies with a small 5-fieldcnodestruct (orig,nodeType,label,parent,children) that holds only what Chawathe needs.dst.Parent == xandsrc.parent == w), so parent verification drops fromlcs()into a single 1D slice buffer, adding fast-paths forinternal/actions/action_test.goto testcnodetree copying and child insertion directly.