feat(engine): reassign stolen containers during bottom-up matching - #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ifstatement gets deleted, inner blocks inside theifcan greedily claim the outer function body's container because they share common leaf statements.Moveactions for all sibling statements.What Changed
ContestContainersininternal/engine/bottom-up.goto reassign containers claimed by nested inner T1 nodes back to their proper outer T1 parent.Mapping.Removeininternal/engine/mapping.gosom.Pairsstays in sync when mappings are reassigned.ContestContainersinsideMatchininternal/engine/matcher.goright after bottom-up matching finishes.go_gin_fix_lint,py_requests_refactor_prefer, andrust_tokio_test_tests_when) because the redundant move and delete/insert actions are now gone.Visual Comparison
tests/testdata/go_gin_fix_lintBefore
After