Fix XER collection iteration, data mappings, and round-trip writes - #38
Open
hurtlovewow wants to merge 2 commits into
Open
Fix XER collection iteration, data mappings, and round-trip writes#38hurtlovewow wants to merge 2 commits into
hurtlovewow wants to merge 2 commits into
Conversation
HassanEmam
marked this pull request as ready for review
August 19, 2026 00:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
TASKPREDproject mapping and predecessor lookup behavior.Readerinstance instead of using global state.ROLErecords and preserve role/rate/resource-category tables during XER write/read round trips.lag_hr_cntbehavior.Root causes
The collection iterators retained mutable cursor state between iterations; the reader relied on the CSV module's 131,072-character default field limit; several model constructors and
find_by_id()methods contained copy/paste column or identifier errors; and some parsed XER tables were omitted by the writer. DCMA14 also divided by zero and compared dates when one side was missing.Validation
pytest -q— 44 passedpython3 -m compileall -q xerparser testsgit diff --checkThe feature requests for activity-relationship editing (#7), DCMA-14 visualisation (#10), and EVA/CPI/SPI charts (#13) are intentionally not included in this bug-fix PR.