Skip to content

Add Solar Orbiter SPICE datasource and ingestion support - #508

Open
SalimHachemaoui wants to merge 4 commits into
Helioviewer-Project:mainfrom
SalimHachemaoui:feature/spice-datasource-migration
Open

Add Solar Orbiter SPICE datasource and ingestion support#508
SalimHachemaoui wants to merge 4 commits into
Helioviewer-Project:mainfrom
SalimHachemaoui:feature/spice-datasource-migration

Conversation

@SalimHachemaoui

Copy link
Copy Markdown

10 files changed
317 insertions
18 deletions

@dgarciabriseno

Copy link
Copy Markdown
Contributor

I plan to review this soon. Likely next week.
Can you attach some of the SPICE jp2 files here so I can test?

@SalimHachemaoui

Copy link
Copy Markdown
Author

Hi Daniel,
I’ve attached an archive containing 10 sample SPICE JP2 files from December 2, 2023. Let me know if you need additional files covering other dates or spectral lines.
spice-jp2-samples.tar.gz

@dgarciabriseno

Copy link
Copy Markdown
Contributor

Ingestion is working, this PR is messing the rendering part.

There needs to be a src/Image/ImageType/SPICEImage.php that describes how to render it / apply colors, or leave it grayscale. You can refer to src/Image/ImageType/SJIImage.php, it can be really minimal.

@dgarciabriseno dgarciabriseno left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good, but PR is incomplete, needs a SPICEImage.php to enable turning jp2 files into tiles.

@dgarciabriseno

Copy link
Copy Markdown
Contributor

I think you have this already since you showed a UI that was rendering tiles already, so maybe just missed a git add.

@SalimHachemaoui

Copy link
Copy Markdown
Author

Hi @dgarciabriseno,
You’re right I have already prepared the code needed to render SPICE images correctly. I’m planning to submit it in a separate PR focused specifically on SPICE rendering, as soon as I receive confirmation from @ebuchlin
In the meantime, could you please validate this PR for the datasource and ingestion support? I’ll submit the separate SPICE rendering PR shortly afterward.

dgarciabriseno
dgarciabriseno previously approved these changes Aug 13, 2026
@SalimHachemaoui

Copy link
Copy Markdown
Author

It looks like the Playwright check is failing during the Docker setup because the helioviewer-coordinator-1 container becomes unhealthy:

Container helioviewer-coordinator-1  Error
dependency failed to start: container helioviewer-coordinator-1 is unhealthy
Error: Process completed with exit code 1.

The Playwright tests therefore don't appear to actually start.
Could this be related to the CI/Docker environment rather than the changes in this PR? Please let me know if there is anything I should update on my side.

@mudhoney

mudhoney commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

@SalimHachemaoui , @dgarciabriseno
FYI
I have updated the PR for missing SPICE info for frontend requests validation file docroot/schema/image_layer.schema.json
472da68

@dgarciabriseno

dgarciabriseno commented Aug 20, 2026 via email

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants