Skip to content

Add SPICE image rendering with full PC WCS support - #513

Open
SalimHachemaoui wants to merge 1 commit into
Helioviewer-Project:mainfrom
SalimHachemaoui:feature/full-pc-wcs-support
Open

Add SPICE image rendering with full PC WCS support#513
SalimHachemaoui wants to merge 1 commit into
Helioviewer-Project:mainfrom
SalimHachemaoui:feature/full-pc-wcs-support

Conversation

@SalimHachemaoui

Copy link
Copy Markdown

No description provided.

@mudhoney

Copy link
Copy Markdown
Contributor

Hi @SalimHachemaoui

I made couple of tests with rendering of SPICE in our web frontend, I am seeing SPICE images kind of stretched.
I m attaching the screenshot, would you check if there is problem with the rendering?
2023_12_02_18_19_21_AIA_304__SPICE_70 6

@SalimHachemaoui

Copy link
Copy Markdown
Author

Hi @mudhoney ,
You are right. I reproduced the issue locally and confirmed that the interactive SPICE rendering works correctly, but the generated screenshot does not yet apply the full SPICE WCS geometry.
The screenshot generation uses a separate server-side rendering path that still assumes a single scalar image scale. As a result, the anisotropic X/Y scales and PC matrix are not applied, which causes the stretched vertical image shown in your screenshot.
I am working on this remaining part and will update the PR once screenshot generation renders SPICE consistently with the interactive viewport.
Thanks for identifying and testing this.

@mudhoney

Copy link
Copy Markdown
Contributor

Hi @SalimHachemaoui

Thank you for following up and effort to fix the problem.

I am able to generate the same problem in interactive frontend too also for the screenshots, You can follow this link https://necdet.helioviewer.org/load/d7c388a9aa8efc0812142f2bf7418cf3396501c8ddcb97d663c69f31595ea4e5 to see the problem.

@SalimHachemaoui

Copy link
Copy Markdown
Author

Hi @mudhoney ,
Thank you for the link. I understand now that the issue is reproducible in both the interactive frontend and the server-generated screenshots on your deployment.
My local interactive test was using a locally modified version of the frontend and @helioviewer/sun, which explains why SPICE appeared correctly there. Those frontend changes are not included in the current API PR.
I am now checking both rendering paths separately:
the client-side WCS transformation used by the interactive frontend;
the server-side composite renderer used for screenshots and movies.
I will avoid pushing the current experimental screenshot fix until both paths use the same SPICE WCS conventions and produce consistent results. Thank you for providing the reproducible state.
image

@dgarciabriseno

dgarciabriseno commented Aug 20, 2026 via email

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants