feat: add v1.2.0 Phase 1 progress core and optimize CI - #22
Merged
HelloThisWorld merged 4 commits intoJul 31, 2026
Conversation
HelloThisWorld
marked this pull request as ready for review
July 31, 2026 19:47
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci-gateresult.Related issues
Closes #
Detailed changes
CI optimization
The exact PR base-to-head diff is classified as:
docs-only: every file is in the conservative documentation allowlist; runs quick validation only.code: any non-documentation change that is not delivery-sensitive; runs quick validation plus one x64 Release build and relevant compiled tests.delivery: workflows, build/project/dependency configuration, manifests, version/branding, packaging, installer, portable, signing, attestation, release, or equivalent delivery-sensitive paths; runs quick validation once, Debug and Release builds/tests, packaging, lifecycle tests, and the existing distribution allowlist.The
ci:fullanddeliverylabels force delivery validation. Manual dispatch supportsauto,fast, andfull. New PR commits cancel obsolete runs through PR-scoped concurrency.The unrestricted push trigger and duplicate
winterm-full-build.ymlPR path are removed, so merging a normal PR tomainno longer repeats ordinary validation. The separatev*tag-triggered.github/workflows/release.ymlworkflow is unchanged and remains the authoritative release build.ci-gateusesif: always(), depends on classification and every conditional job, rejects missing/failed/cancelled required work, and accepts skipped jobs only when the selected class does not require them.Visual Progress Phase 1
TerminalCore→ControlCore→TermControl→TerminalPaneContent→Pane.visualProgress.enabledglobal setting.WINTERM_DISABLE_VISUAL_PROGRESS=1always disables the feature.Validation performed
Passed locally on Windows x64 with Visual Studio/MSBuild 17.14.51 and Windows SDK 10.0.22621.0:
./scripts/winterm/test-ci-classification.ps1./scripts/winterm/test-release-workflow.ps1./scripts/winterm/test-visual-progress.ps1 -SourceOnly -Configuration Release -Platform x64./scripts/winterm/test.ps1 -Suite Smoke -Configuration Release -Platform x64./scripts/winterm/build.ps1 -Configuration Release -Platform x64 -IncludeTests./scripts/winterm/test.ps1 -Suite Relevant -Configuration Release -Platform x64scripts/winterm/**/*.ps1files.github/workflows/*.ymlfilesgit diff --checkfor each staged commit and the complete branch diffThe final Relevant run passed the Settings Model group (including all new Visual Progress tests) and all 30 Control tests. The Release build completed with only existing PRI/XAML resource warnings.
Not run locally:
scripts/winterm/invoke-visual-progress-smoke.ps1is included for that exercise.GitHub Actions (winTerm validation run 30656749400): passed.
delivery.ci-gate: passed.Known limitations and Phase 2 exclusions
Branch protection
After this workflow lands, repository branch protection should require the single stable
ci-gatecheck. This PR does not change repository settings programmatically.Checklist
winterm.exe, and Microsoft Terminal coexistence remain isolated.