Repository navigation
Follow /v1 2026-10-25: pagination totals may be absent - #213
Merged
Merged
Conversation
Take the published OpenAPI document, regenerate the client, and let the alerts list work without page, total and total_pages: --all ends on a null cursor or a short page, and the page footer is skipped. Closes #210 Signed-off-by: d0ubl3g <48954024+d0ubl3g@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #210.
openapi/v1.jsonis now the published 2026-10-25 document; the client is regenerated (AlertsPaginationfor the alerts list, whose totals became optional).alerts list --allstops on a nullnext_cursoror a short page when the totals are absent, and keeps the existing rules when they are present; thePage N of Mfooter prints only when all three counts are there.--jsonand--csvpass the response through, so they now includeupdated_at, and--sortgainsupdated_at./v1/meuserandbetaare optional fields in the generated type, so a null user (API keys) is still accepted.Tests: 344 passed; clippy, fmt and
cargo xtask codegen --checkclean.