Repository navigation
fix(trace): preserve active rows and honest failures on current SDK - #17
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A visitor following a narrated comparison could lose the active trace row because scrolling ran before the SDK mounted it. Parent updates also replaced existing row DOM, and rejected requests appeared as completed spans. This moves scrolling into the row, uses the SDK's existing stable render-function API, and maps error events to failed spans.
Updates the trace framework to exact
@assistant-ui/react-o11y0.0.47 and@assistant-ui/store0.3.20, including the required tap/Radix closure. The provider usesAuiConfig/config. The old SDK retained a referenced MessagePort after SSR; the new real-wrapper regression requires 55 realistic renders and natural subprocess exit. Unrelated dependency records, model/provider behavior and CSS are unchanged.Validation on the frozen five-file candidate:
Costs and limits: JavaScript grows by 5,036 gzip bytes; CSS is identical. Ordered local update-to-DOM observations do not show a speedup. The existing 390px layout's 20px trace viewport remains a separate visual issue. No production, model-quality or unlimited-memory claim; no paid provider evaluation. Model-refresh PR #16 remains separate.
Evidence qualification (2026-10-14): Windows
npm ls --all --jsonexited 0 but reported the same six extraneous packages in the baseline and every candidate/reviewer capture; the saved dependency tree is not warning-free. The whole-app foreground 100-turn run used candidate2; final candidate3 separately proves rejected-request recovery and the private sustained lifecycle cases. The 55 SSR renders are one scenario within the 61 outer tests, not additional tests. No new runtime rerun or cleanup is implied by this reconciliation.