Skip to content

Error is thrown if drop is destroyed before hover timeout executes #169

Description

@zmdavis
  1. Create a drop that opens on hover with a hoverOpenDelay
  2. Hover over target, which sets a timeout
  3. Destroy the drop (before timeout executes)
  4. Timeout is not cleared, and when it executes a js error is thrown

The actual error thrown is Cannot read property 'parentNode' of null and is caused by https://github.com/HubSpot/drop/blob/master/src/js/drop.js#L374

If this.drop is null when open is called it should probably just return instead of trying to do things.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions