fix(axiom): send the event timestamp to Axiom and surface ingest failures - #633
Merged
Conversation
🦋 Changeset detectedLatest commit: f030d01 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Axiom adapter now sends the event's own
timestampas Axiom's_timevia thetimestamp-fieldingest parameter, so batched and retried events keep their original time instead of being stamped at ingest. It also logs partial ingest failures and schema warnings that Axiom's ingest response can carry on a 2xx. The shared HTTP transport now retries429responses with backoff alongside5xx, which matters for Axiom's rate limits.Why
Research on Axiom's conventions (Linear doc "Axiom: research for a first-class evlog adapter") found two gaps: the adapter never set
timestamp-field, so every event was timestamped at ingest time, and partial ingest failures were silently accepted. Axiom rate limits return 429, which the transport did not retry.Checks
pnpm run lintpassespnpm run typecheckpassespnpm run testpassespnpm api:snapshotpasses, no public surface changepnpm content:linton the updated docs page: score 100, no findingsChangeset:
.changeset/axiom-timestamp-field.md(patch).