Preserve HTTP image URLs in the chat feed - #220
Open
NubsCarson wants to merge 1 commit into
Open
Conversation
Author
|
Before and after from the real panel page rendered in headless Chrome at side-panel width, same synthetic feed both times. On main every cover and the reader hero carries the stringified RegExp as its src, so the frame shows a broken image; with this patch the same rows render their covers.
Reader view after the fix, hero image rendering above the post body:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing feed-image helper returns a RegExp instead of the image URL, so feed covers and reader images fail to render. Return the original URL for HTTP(S) sources and an empty string for unsupported sources. This fixes the pre-existing behavior disclosed in #218.
The patch updates the helper and its regression coverage, and regenerates the panel from current main. All 429 core tests pass with Chrome required, as do the core and panel typechecks. The helper continues to serve both image display sites; no new dependencies or interfaces are added.