Skip to content

Reject nested positional products in Sector - #290

Merged
mtfishman merged 3 commits into
mainfrom
mf/sector-flatten
Oct 27, 2026
Merged

mtfishman merged 3 commits into
mainfrom
mf/sector-flatten

Conversation

@mtfishman

@mtfishman mtfishman commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Summary

Sector(U1(0), fSU2(0)) built a product holding another product as a factor, rather than the flat U1(0) × fSU2(0) that was almost always meant, and TensorKitSectors cannot infer the fusion and braiding styles of the nested product. Sector now throws for a positional product factor and points to sectorproduct (or ×), which splices it in.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.79%. Comparing base (a906086) to head (7f3c2b3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   85.78%   85.79%   +0.01%     
==========================================
  Files          40       40              
  Lines        2842     2845       +3     
==========================================
+ Hits         2438     2441       +3     
  Misses        404      404              
Flag Coverage Δ
docs 16.87% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mtfishman and others added 2 commits October 26, 2026 21:59
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@mtfishman mtfishman changed the title Flatten nested products in Sector Reject nested positional products in Sector Oct 27, 2026
@mtfishman
mtfishman enabled auto-merge (squash) October 27, 2026 02:35
@mtfishman
mtfishman merged commit a569fd4 into main Oct 27, 2026
19 checks passed
@mtfishman
mtfishman deleted the mf/sector-flatten branch October 27, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant