Repository navigation
Read single axes of a GradedArray directly - #292
Merged
Merged
Conversation
`axes(a, d)` returns the stored axis instead of going through Base's fallback, which builds the whole tuple and returns a union with a trailing `OneTo(1)`. An out-of-range `d` now throws. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
==========================================
+ Coverage 85.79% 85.80% +0.01%
==========================================
Files 40 40
Lines 2844 2847 +3
==========================================
+ Hits 2440 2443 +3
Misses 404 404
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
axes(a, d)on aGradedArrayfell back to Base's method, which returns either the axis or a trailingOneTo(1), so contraction and permutation code reading axes one at a time could not infer it. Reading the stored axis directly makes allocating a permuted output about 40% faster. An out-of-rangednow throws.