-
Notifications
You must be signed in to change notification settings - Fork 8
feat(lib): Enable Nullable analysis and fix warnings #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
78 commits
Select commit
Hold shift + click to select a range
d20292f
Fix CS8625 in base/common files.
MayaKirova 92a5801
Fix CS8625 in component files.
MayaKirova 45e4784
Fix CS8618 by making uninitialized props nullable.
MayaKirova c42a849
Fix CS8600 - null conversion issues.
MayaKirova 6672f37
Fix for CS8601 - null ref assignments.
MayaKirova c1d5fa5
Fix CS8602 - mark as not null.
MayaKirova 9c49ff1
Fix CS8603 by marking types/return types as nullable.
MayaKirova 32cbc78
Fix CS8604: Adds guards / ArgumentNullException.ThrowIfNull / signat…
MayaKirova c69deca
Adding null-forgiving operators where possible.
MayaKirova 825c5a9
Fix CS8769 - set nullable object params so they match props.
MayaKirova 5f58952
Fix casting to nullable types.
MayaKirova a2c457f
Minor tweaks.
MayaKirova ed12c2d
Few more tweaks around nullable params.
MayaKirova 0d73f52
Refactor null checks for data sources in DataSourceManager and adjust…
MayaKirova 1a6b9f1
Add more null checks.
MayaKirova 92dc9bd
Merge branch 'master' into mkirova/nullable
MayaKirova 187d80a
Initial plan
Copilot e56d8c5
Address review feedback: null guards, dash encoding, delegate fix
Copilot d522e78
Fix type mismatch.
MayaKirova d0a62ac
Merge pull request #366 from IgniteUI/copilot/fix-comments-in-review-…
MayaKirova 5b1b057
Apply suggestions from code review
MayaKirova 2a7b86a
Avoid null-forgiving operator where possible in favor of actual null …
MayaKirova 30c9576
Replace null-forgiving operator with checks.
MayaKirova e05e740
Add null checks for collection items in CollectionAdapter
MayaKirova f79aafd
Remove a few more null-forgiving operators in favor of proper null ch…
MayaKirova 8569a83
Replacing null-forgiving operators with null checks.
MayaKirova ac1b099
Marking ColumnData as nullable, since it explicitly gets set to null …
MayaKirova 2c1fc66
Fix formatting.
MayaKirova 62fd3bc
Final codeql fixe.s.
MayaKirova 20f3d90
Apply suggestion
MayaKirova 0a5b9be
Fix null check and update _inprocRuntime invocation.
MayaKirova 5bc62b9
Enable nullable warnings in Directory.Build.props and remove nullable…
MayaKirova 054ffc0
Remove redundant null-forgiving operators.
MayaKirova 4305f2e
Remove redundant null-forgiving operators.
MayaKirova 207e0cd
fix: two behavioral changes/regressions from nullable annotation pass
damyanpetev 0ea0534
Merge pull request #372 from IgniteUI/dpetev/nullable-unmarshalled-fix
MayaKirova 40fff10
Make EventArg Detail non-nullable.
MayaKirova c6570c4
Make DateTime across components non-nullable.
MayaKirova 3e16486
Adjust public props to match type of client component props and defau…
MayaKirova 9d207a7
fix formatting
MayaKirova c1ea51e
Potential fix for pull request finding 'Constant condition'
MayaKirova 7b7fea6
Remove default object fallback.
MayaKirova 74a0217
Fix tests.
MayaKirova 2b2c844
Merge branch 'mkirova/nullable' of https://github.com/IgniteUI/ignite…
MayaKirova ee92352
ButtonGroup selection event args are nullable string. So setting it t…
MayaKirova 56586ce
Remove redundant null-forgiving operators.
MayaKirova 2a4099f
Initial plan
Copilot 00dc2d6
Fix review-thread follow-ups and encoding cleanup
Copilot 6d5b296
Merge pull request #384 from IgniteUI/copilot/fix-review-comments
MayaKirova 5ef77b9
Adjust Chat API methods and evt args to match client-side nullability.
MayaKirova 11fdf60
Merge branch 'mkirova/nullable' of https://github.com/IgniteUI/ignite…
MayaKirova 09b2be5
Adjust API methods and evt args to match client-side nullability. Upd…
MayaKirova 611ac49
Purge null forgiving operators in favor of fallbacks or actual null c…
MayaKirova bb9cb43
Merge branch 'master' into mkirova/nullable
MayaKirova bc12dd8
Initial plan
Copilot db82c38
Fix null component TCS race in dynamic content
Copilot 8a2b7fe
Merge pull request #386 from IgniteUI/copilot/fix-review-comment-365
MayaKirova 7e8e8ed
Adjust to wc api.
MayaKirova 7f60486
Merge branch 'mkirova/nullable' of https://github.com/IgniteUI/ignite…
MayaKirova 746f4c4
Merge branch 'master' into mkirova/nullable
MayaKirova f298c23
Merge branch 'master' into mkirova/nullable
MayaKirova a473f17
refactor: update DateRangePicker resource strings to support nullable…
MayaKirova 276f875
chore: update changelog with breaking changes for public API nullability
MayaKirova 1b9fe3a
Remove base classes and RenderSerializer.
MayaKirova fc104be
chore: update changelog to clarify public API nullability changes
MayaKirova 8bbbd91
Merge from master.
MayaKirova 49c709f
Address comments.
MayaKirova 2aab6c2
Keep the date picker members nullable as in 0.1.0
damyanpetev 4e30871
Align component nullability with the web component contracts
damyanpetev 7482cc3
Restore master null handling in the base layer without null-forgiving…
damyanpetev 2b8b7e9
Describe the reference-type nullability changes as clarified, not tig…
damyanpetev b304ed6
Look up event payloads with TryGetValue
damyanpetev 5d457d6
Merge remote-tracking branch 'origin/master' into mkirova/nullable
damyanpetev 0d3344a
Make required web component members non-nullable on render contexts, …
damyanpetev 92bb7cb
Make chat message attachments, reactions and suggestions non-nullable…
damyanpetev d797519
Document nullability conventions for C#
damyanpetev 74c3eb1
Merge remote-tracking branch 'origin/master' into mkirova/nullable
damyanpetev b2c20fa
Keep IgbInput InputMode and Autocomplete unset by default
damyanpetev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.