Restore early disposal state and bypass cleanup send guard in BaseRendererControl

[Copilot]

This follow-up keeps PR #399 focused on cleanup delivery: restore early disposal state publication and send cleanup through a dedicated path that is not blocked by normal disposed-message guards. It preserves existing cleanup delivery/idempotency tests without pulling in the queue/disposal locking work tracked separately in #394.

• Disposal ordering (reverted to early publication)

  • DisposeAsync now sets disposedValue = true before runtime reevaluation and before awaiting cleanup.
  • Removed the late disposedValue assignment from the finally block.

• Cleanup send path (dedicated bypass)

  • TrySendCleanupAsync still clears _messageQueue.
  • Cleanup now calls SendJsonImmediate(m) directly instead of SendMessageImmediate(m), so cleanup is delivered even after normal sends are closed by disposal.

• Intent made explicit

  • Added a concise inline comment clarifying that disposal has already closed normal sends and cleanup intentionally bypasses the disposed guard.

disposedValue = true;
_shouldReevaluateRuntime = true;
await TrySendCleanupAsync().ConfigureAwait(false);

// ...

_messageQueue.Clear();
// Normal sends are already closed by disposal; cleanup intentionally bypasses the disposed guard.
await SendJsonImmediate(m).ConfigureAwait(false);

[Copilot]

🟢 Approval recommended

The changes are small, consistent with the stated intent, and directly address cleanup delivery after disposal without altering broader queue/locking behavior.

Pull request overview

This PR adjusts BaseRendererControl disposal behavior to ensure the cleanup message is still delivered even after the normal disposed-message guards have closed standard sends, aligning disposal ordering with the intended cleanup-delivery semantics described in PR #394/#399 context.

Changes:

• Publish disposedValue = true early in DisposeAsync, before reevaluating runtime validity and before awaiting cleanup.
• Send the cleanup message via SendJsonImmediate (bypassing the disposed guard in SendMessageImmediate) while still clearing the pending message queue.
• Add an inline comment documenting that cleanup intentionally bypasses the normal disposed send guard.

File summaries

File	Description
src/componentsBase/BaseRendererControl.cs	Restores early disposal state publication and routes cleanup through a dedicated send path that isn’t blocked by normal disposed-message guards.

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.