refactor: Remove obsolete browser lifecycle wrapper APIs - #415
Merged
damyanpetev merged 4 commits intoSep 14, 2026
Conversation
Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate and remove obsolete public lifecycle-wrapper APIs
Remove obsolete browser lifecycle wrapper APIs
Sep 11, 2026
damyanpetev
reviewed
Sep 14, 2026
Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
damyanpetev
approved these changes
Sep 14, 2026
damyanpetev
marked this pull request as ready for review
September 14, 2026 06:28
damyanpetev
changed the title
damyanpetev
enabled auto-merge (squash)
September 14, 2026 06:30
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Public API removals lack the required [Obsolete] compatibility period.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Removes public C# browser lifecycle wrapper APIs from five Blazor components while leaving native TypeScript lifecycle callbacks unchanged.
Changes:
- Removes connected-callback wrappers.
- Removes disconnected-callback wrappers.
- Preserves browser-managed TypeScript lifecycle behavior.
File summaries
| File | Review findings |
|---|---|
src/components/Blazor/TreeItem.cs |
Critical: Restore wrappers as [Obsolete] for one major version before removal. (1 vote) |
src/components/Blazor/Tree.cs |
Critical: Restore wrappers with the required [Obsolete] compatibility period. (3 votes) |
src/components/Blazor/RatingSymbol.cs |
Critical: Retain wrappers as [Obsolete] for one major version. (3 votes) |
src/components/Blazor/Dropdown.cs |
Critical: Retain wrappers as [Obsolete] before deletion. (3 votes) |
src/components/Blazor/BaseAlertLike.cs |
Critical: Retain wrappers as [Obsolete] for one major version. (3 votes) |
Review details
Suppressed comments (1)
src/components/Blazor/TreeItem.cs:263
- These public lifecycle methods are being removed without an
[Obsolete]migration period, so existing consumers that call eitherConnectedCallback*orDisconnectedCallback*will stop compiling immediately. The repository policy requires public APIs to remain marked obsolete for at least one major version before removal (.github/CONTRIBUTING.md:185-187); please retain these wrappers with that deprecation and document the eventual breaking removal, or defer deletion to the appropriate major release.
/// <summary>
- Files reviewed: 5/5 changed files
- Comments generated: 5
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dkamburov
approved these changes
Sep 14, 2026
damyanpetev
deleted the
copilot/remove-obsolete-lifecycle-wrapper-apis
branch
September 14, 2026 07:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes public C# methods that manually dispatch browser custom-element lifecycle callbacks. Native TypeScript
connectedCallback/disconnectedCallbackimplementations remain browser-managed and unchanged.API cleanup
ConnectedCallbackAsync,ConnectedCallback,DisconnectedCallbackAsync, andDisconnectedCallbackfrom:IgbTreeItemIgbTreeIgbBaseAlertLikeIgbRatingSymbolIgbDropdown