Skip to content

[jp-sync] Sync Angular carousel topic path move (layouts/carousel.mdx) - #869

Closed
github-actions[bot] wants to merge 2 commits into
vnextfrom
jp-sync/carousel-layouts-move-3e01a11b6698993a
Closed

github-actions[bot] wants to merge 2 commits into
vnextfrom
jp-sync/carousel-layouts-move-3e01a11b6698993a

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Original author: IMinchev64 61944284+IMinchev64@users.noreply.github.com

Syncs the Japanese Angular documentation with the changes merged in #506 ("feat(docs): update carousel xplat topic"), which moved the Angular Carousel topic to the shared xplat-generated location (components/layouts/carousel.mdx, git-ignored, expanded at build time) and removed the old standalone components/carousel.mdx source.

Files processed:

  • docs/angular/src/content/en/components/toc.json → docs/angular/src/content/jp/components/toc.json
    Updated the Carousel entry's href from carousel.mdx to layouts/carousel.mdx.
  • docs/angular/src/content/en/components/general/cli/component-templates.mdx → docs/angular/src/content/jp/components/general/cli/component-templates.mdx
    Updated the IgxCarousel link target from ../../carousel.mdx to ../../layouts/carousel.mdx.
  • docs/angular/src/content/en/components/themes/roundness.mdx → docs/angular/src/content/jp/components/themes/roundness.mdx
    Updated the Carousel link target to point at the new layouts/carousel path.
  • docs/angular/src/content/en/components/carousel.mdx (removed) → docs/angular/src/content/jp/components/carousel.mdx (removed)
    The old English carousel topic source was deleted since its content now lives in the xplat-generated layouts/carousel.mdx page; the orphaned Japanese counterpart was removed to match.

Note: the new components/layouts/carousel.mdx Angular page itself is generated at build time from docs/xplat/src/content/{lang}/components/layouts/carousel.mdx (via generate-grids-style expansion) and is git-ignored, so it does not appear as a file to translate here — analogous to the grids_templates/ handling described in the sync instructions.

Generated by Sync Japanese Documentation (Angular) · copilot · auto · 101.9 AIC · ⌖ 3.49 AIC · ⊞ 9.7K · ◷

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@IG-Mori

IG-Mori commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Japanese native check

No issues found in the changed lines. They are link path updates only (carousel.mdx → layouts/carousel.mdx), and they match the English source.

Notes from local verification (outside what this PR alone can show)

1. This branch predates #870, so on its own the Carousel page is missing.
On this branch, docs/xplat/src/content/jp/toc.json still marks Carousel with "exclude": ["Angular"]. As a result, layouts/carousel.mdx is not generated for Angular JP. The sidebar drops the Carousel entry, and /layouts/carousel returns 404. This is not a problem after merging with current vnext (git merge-tree shows no conflicts): the entry then appears in the Layouts group (5th item, no badge).

2. With vnext merged, /layouts/carousel returns 500 because of missing JP images.
Running npm run dev:jp fails with Cannot find module '@xplat-images/anatomy-content-light/carousel-lt-a.png'. For JP, @xplat-images resolves to docs/angular/src/content/jp/images/. The page imports 9 images from there, but #506 added them only under en/images/, and #870 did not copy them:

  • anatomy-content-light/carousel-lt-a.png
  • carousel/carousel_do1.png, carousel_do1@2x.png
  • carousel/carousel_do2.png, carousel_do2@2x.png
  • carousel/carousel_do_not1.png, carousel_do_not1@2x.png
  • carousel/carousel_do_not2.png, carousel_do_not2@2x.png

Avatar had the same issue, and f8bd08c fixed it by copying the EN images into jp/images/. A JP build (build:jp) will likely fail the same way, but I have not run it.

Not verified: how the Carousel page renders and its heading, and whether the sidebar filter finds the entry in the browser. Both depend on the images being added first.

@ChronosSF

Copy link
Copy Markdown
Member

The sync pipeline isn't very good with ensuring assets land where they should for angular. I have separate prs that will address these. Give me some time to get everything where it should be including a CI build that also checks JP .

@ChronosSF

Copy link
Copy Markdown
Member

@IG-Mori , I fixed the missing images and links separately, this PR is now noop against vnext. Please, verify the carousel topic on staging but I am closing this .

@ChronosSF ChronosSF closed this Sep 29, 2026
@ChronosSF
ChronosSF deleted the jp-sync/carousel-layouts-move-3e01a11b6698993a branch September 29, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants