[jp-sync] Sync Angular carousel topic path move (layouts/carousel.mdx) - #869
github-actions[bot] wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Japanese native checkNo issues found in the changed lines. They are link path updates only ( Notes from local verification (outside what this PR alone can show)1. This branch predates #870, so on its own the Carousel page is missing. 2. With
Avatar had the same issue, and f8bd08c fixed it by copying the EN images into Not verified: how the Carousel page renders and its heading, and whether the sidebar filter finds the entry in the browser. Both depend on the images being added first. |
|
The sync pipeline isn't very good with ensuring assets land where they should for angular. I have separate prs that will address these. Give me some time to get everything where it should be including a CI build that also checks JP . |
|
@IG-Mori , I fixed the missing images and links separately, this PR is now noop against vnext. Please, verify the carousel topic on staging but I am closing this . |
Original author: IMinchev64 61944284+IMinchev64@users.noreply.github.com
Syncs the Japanese Angular documentation with the changes merged in #506 ("feat(docs): update carousel xplat topic"), which moved the Angular Carousel topic to the shared xplat-generated location (
components/layouts/carousel.mdx, git-ignored, expanded at build time) and removed the old standalonecomponents/carousel.mdxsource.Files processed:
docs/angular/src/content/en/components/toc.json→docs/angular/src/content/jp/components/toc.jsonUpdated the Carousel entry's
hreffromcarousel.mdxtolayouts/carousel.mdx.docs/angular/src/content/en/components/general/cli/component-templates.mdx→docs/angular/src/content/jp/components/general/cli/component-templates.mdxUpdated the
IgxCarousellink target from../../carousel.mdxto../../layouts/carousel.mdx.docs/angular/src/content/en/components/themes/roundness.mdx→docs/angular/src/content/jp/components/themes/roundness.mdxUpdated the Carousel link target to point at the new
layouts/carouselpath.docs/angular/src/content/en/components/carousel.mdx(removed) →docs/angular/src/content/jp/components/carousel.mdx(removed)The old English carousel topic source was deleted since its content now lives in the xplat-generated
layouts/carousel.mdxpage; the orphaned Japanese counterpart was removed to match.Note: the new
components/layouts/carousel.mdxAngular page itself is generated at build time fromdocs/xplat/src/content/{lang}/components/layouts/carousel.mdx(viagenerate-grids-style expansion) and is git-ignored, so it does not appear as a file to translate here — analogous to thegrids_templates/handling described in the sync instructions.