fix(ci): trigger Angular deploys on xplat changes - #874
Merged
Merged
Conversation
Angular documentation content is generated from xplat: docs/angular/scripts/ sync-generated.mjs copies docs/xplat/generated/Angular/<lang> into docs/angular/src/content/<lang> on every build. But both Angular deploy workflows listed 'docs/xplat/**' under paths-ignore, so a push that touched only xplat never redeployed the Angular docs — the content silently lagged until some unrelated Angular file happened to change. This is how the carousel JP breakage (#873) went unnoticed for a day: #870 touched only docs/xplat/**, so Build And Deploy Angular Documentation JP was skipped, and the failure surfaced on the next unrelated push. Before that, the last Angular JP run was 2026-09-04 — 25 days earlier. Dropping the entry is enough. The per-locale '**/en/**', '**/jp/**' and '**/kr/**' filters still apply, so an xplat EN change triggers only the EN Angular deploy and an xplat JP change only the JP one. The reverse direction already behaves correctly: cd-xplat-en.yml and cd-xplat-jp.yml both paths-ignore 'docs/angular/**', so Angular-only changes do not trigger xplat deploys. No change needed there. Fixes #402 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #402.
Problem
Angular documentation content is generated from xplat:
docs/angular/scripts/sync-generated.mjscopiesdocs/xplat/generated/Angular/<lang>intodocs/angular/src/content/<lang>on every build. But both Angular deploy workflows listed'docs/xplat/**'underpaths-ignore.So a push that touched only xplat never redeployed the Angular docs. The content silently lagged until some unrelated Angular file happened to change — which could be days or weeks later.
Evidence
This is exactly how the carousel JP breakage (#873) went unnoticed:
docs/xplat/.Build And Deploy Angular Documentation JPwas skipped; only the xplat JP deploy, CodeQL and the link check ran on merge commit39b4236.docs/angular/src/content/jp/.Change
Drop
'docs/xplat/**'frompaths-ignoreincd-angular-en.ymlandcd-angular-jp.yml. That is the whole fix.The per-locale filters still do the right thing, so this does not over-trigger:
docs/xplat/src/content/en/…**/jp/**docs/xplat/src/content/jp/…**/en/**docs/xplat/scripts/,astro.config.tsThe last row is intended — the generator and config feed both locales.
The reverse direction is already correct
cd-xplat-en.ymlandcd-xplat-jp.ymlboth alreadypaths-ignore'docs/angular/**', so Angular-only changes do not trigger xplat deploys. No change needed there.Related
🤖 Generated with Claude Code