feat: Added skeleton component - #2205
Draft
rkaraivanov wants to merge 7 commits into
Draft
rkaraivanov wants to merge 7 commits into
rkaraivanov wants to merge 7 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Skeleton web component to the Ignite UI Web Components library, including its Storybook documentation, base styling, unit tests, and package exports so it can be consumed like the existing components.
Changes:
- Added
IgcSkeletonComponentimplementation with loading/animation behavior and measurement logic. - Added Storybook stories demonstrating common layouts and observer-driven remeasurement scenarios.
- Integrated the component into the public exports and
defineAllComponents()registration list, plus added base SCSS and unit tests.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| stories/skeleton.stories.ts | Adds Storybook coverage for the new skeleton component, including demos. |
| src/index.ts | Exposes IgcSkeletonComponent from the package entry point. |
| src/components/skeleton/themes/skeleton.base.scss | Introduces base SCSS for overlay/shapes and animation keyframes. |
| src/components/skeleton/skeleton.ts | Implements the new igc-skeleton component behavior and rendering. |
| src/components/skeleton/skeleton.spec.ts | Adds unit + accessibility tests for defaults, loading transitions, and animations. |
| src/components/common/definitions/defineAllComponents.ts | Registers the new component in the “define all” bundle. |
…ories - Make the content inert while loading, and keep the observers idle when not loading, including after a reconnect. - Measure from the host's padding box, so a border or scroll no longer offsets the shapes. - Draw shapes for text next to elements, one per line. Skip hidden and zero-size elements. - Observe each shape source for size changes, and watch attribute and text changes, so shapes stay correct inside a fixed-size host. - Skip the render when the measured shapes are unchanged. - Use createTimer for the reveal, and end `revealing` when loading restarts or the element disconnects. - Take colors from the gray palette (new shared/skeleton.common.scss), add --ig-skeleton-highlight-color, and move the overlay opacity and the fallback radius into CSS. - Add spec.md, a CHANGELOG entry and 15 specs. - Replace the observer demo stories with app scenarios: user list, dashboard, data table, settings form, image loading, load more and styling.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Checklist