Skip to content

feat(pam): clickhouse - #402

Open
lb-vn wants to merge 6 commits into
mainfrom
PAM-466
Open

lb-vn wants to merge 6 commits into
mainfrom
PAM-466

Conversation

@lb-vn

@lb-vn lb-vn commented Sep 17, 2026

Copy link
Copy Markdown
Member

Description 📣

Clickhouse

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@lb-vn
lb-vn requested a review from bernie-g September 17, 2026 00:35
@gitguardian

gitguardian Bot commented Sep 17, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
37371931 Triggered Base64 Basic Authentication 6865c3e packages/pam/handlers/clickhouse/proxy_test.go View secret
37371932 Triggered Username Password 6865c3e packages/pam/handlers/clickhouse/proxy_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@linear

linear Bot commented Sep 17, 2026

Copy link
Copy Markdown

PAM-466

Comment thread packages/pam/handlers/clickhouse/proxy.go Outdated
@veria-ai

veria-ai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

PR overview

All previously flagged issues have been addressed. No open security concerns remain on this pull request.

Security review

No open security issues remain on this pull request.

Fixed/addressed: 4 · PR risk: 0/10

@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 3/5

The PR should not merge until raw ClickHouse bind values are prevented from leaking into persistent session logs.

Findings

  1. P1 Security Bind Values Leak Into Logs
Summary

Adds ClickHouse HTTP-interface support to PAM, including connection testing, credential and database replacement, command-blocking inspection, session auditing, local connection guidance, and resource-type registration.

  • Proxies ClickHouse HTTP requests using account credentials while restricting exposed paths and execution parameters.
  • Handles compressed request inspection and records completed, interrupted, blocked, and failed queries.
  • Adds ClickHouse connection testing and local CLI display configuration.
  • Fixes the four previously reviewed ClickHouse proxy concerns.

Reviews (2) · Last reviewed commit: "address veria"

Comment thread packages/pam/handlers/clickhouse/proxy.go Outdated
Comment thread packages/pam/handlers/clickhouse/proxy.go Outdated
Comment thread packages/pam/handlers/clickhouse/proxy.go
Comment thread packages/pam/handlers/clickhouse/proxy.go Outdated
Comment thread packages/pam/handlers/clickhouse/proxy.go
Comment thread packages/pam/handlers/clickhouse/proxy.go
Comment thread packages/pam/handlers/clickhouse/proxy.go
Comment thread packages/pam/handlers/clickhouse/proxy.go Outdated
Comment thread packages/pam/handlers/clickhouse/proxy.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants